Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change_base_ring does not work for external packages #273

Closed
wbhart opened this issue Feb 15, 2019 · 3 comments
Closed

change_base_ring does not work for external packages #273

wbhart opened this issue Feb 15, 2019 · 3 comments

Comments

@wbhart
Copy link
Contributor

wbhart commented Feb 15, 2019

Because change_base_ring uses the PolynomialRing constructor, it always generates a generic polynomial instead of creating a polynomial belonging to the module in use (e.g. Singular.jl).

I have no idea whatsoever how to fix this problem. Ideas are welcome.

@wbhart
Copy link
Contributor Author

wbhart commented Feb 15, 2019

The only solution seems to be to pass the polynomial ring to change_base_ring. I don't see any other way around it.

@heiderich
Copy link
Contributor

My suggestion in #106 (comment) was to hand over an algebra morphism, which should in particular specify the target ring. I suggested a pair (S, f), where S is the target ring and f the ring homomorphism from the base ring of the polynomial to S. Whether one needs a type for ring homomorphism, I am not sure. Maybe one could just add the target as an additional parameter.

@wbhart
Copy link
Contributor Author

wbhart commented Oct 11, 2019

Now see the more comprehensive ticket #490

@wbhart wbhart closed this as completed Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants