Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coeffs or coefficients? #779

Closed
wbhart opened this issue Mar 10, 2021 · 5 comments
Closed

coeffs or coefficients? #779

wbhart opened this issue Mar 10, 2021 · 5 comments
Labels

Comments

@wbhart
Copy link
Contributor

wbhart commented Mar 10, 2021

The iterator for the coefficients of an MPoly is currently coeffs. This was done to be in line with coeff(f, i).

The iterator for coefficients of a Poly is currently coefficients, in line with our abbreviations policy.

We should change one or the other, but need to choose which. Both would be breaking changes, though I am happy to make the changes across our packages with a deprecation once a decision is made.

@wbhart
Copy link
Contributor Author

wbhart commented Mar 18, 2021

@thofma @fieker @rfourquet

@wbhart
Copy link
Contributor Author

wbhart commented Mar 18, 2021

Sorry, didn't mean to tag you on this one. Decision is already made.

@wbhart
Copy link
Contributor Author

wbhart commented Mar 19, 2021

Hmm, why didn't this close.

@wbhart wbhart closed this as completed Mar 19, 2021
@rfourquet
Copy link
Contributor

I lost track: was it discussed whether coeff should also be renamed to coefficient ?

@wbhart
Copy link
Contributor Author

wbhart commented Mar 19, 2021

We haven't discussed it. I have to review whether that is a good idea or not. It's a super big change so I'm not keen on doing it until all the other is taken care of. But I'll return to it later for a decision if it seems worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants