Move divhigh, mulhigh_n and divexact_low from Misc. Add tests. #801
Conversation
Codecov Report
@@ Coverage Diff @@
## master #801 +/- ##
==========================================
+ Coverage 80.85% 81.01% +0.15%
==========================================
Files 52 52
Lines 17779 17797 +18
==========================================
+ Hits 14375 14418 +43
+ Misses 3404 3379 -25
Continue to review full report at Codecov.
|
|
Can you rebase? Then we see the downstream tests and also if Hecke is failing. |
|
Did you already rebase it? It doesn't seem to need rebasing at the moment. |
|
No, it does not need it, but it would be good if we would do it. Then the downstream will be run that I added in #799. |
wbhart
force-pushed
the
misc_move_truncation
branch
from
70e403b
to
303fef3
Compare
|
Done |
|
Sorry, but I think your master was not up to date, so it is still missing #799. I tried again doing it myself and I still cannot push directly to your branch. Very strange. |
|
Ah oops, it is working, thanks. Ignore my last comment. |
|
Have you tried making yourself a maintainer? |
wbhart
force-pushed
the
misc_move_truncation
branch
from
303fef3
to
d8098ef
Compare
|
I did rebase it a second time. Indeed the latest patch wasn't in. |
|
All the failures here seem to be due to unsatisfiable requirements for package Oscar, which doesn't seem related to this PR. Any chance it could be merged? Or is there something else I need to do here? |
|
Yes, this is expected. This is good to go from my part. @fieker? |
Let me know if you want these three documented.
Note that there were bugs in these, so Hecke tests may now fail as I have corrected their implementation.
I also sped up the third function using unsafe operators.