From 25af38701c950290c625457c945ba8e3e65491a9 Mon Sep 17 00:00:00 2001 From: Chris Archibald Date: Tue, 7 Nov 2023 09:03:46 -0800 Subject: [PATCH 1/4] Update README.md change Enchantment to Enhancement --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index d790a742..9271f982 100644 --- a/README.md +++ b/README.md @@ -35,10 +35,10 @@ go install Click on Issues, we have 6 categories for issues: 1. Report a Bug -- for unexpected error, a crash, or otherwise incorrect behavior. 2. Report a Documentation Error -- for error in our documentation, including typos, mistakes, or outdated information. -3. Request an Enchantment -- For new fields to existing Resources or data sources +3. Request an Enhancement -- For new fields to existing Resources or data sources 4. Request a New Resource, Data Source, or Service 5. Other -- Any other issue that is not covered by the above categories. 6. General Questions -- If you have any general question we have a Discord channel for that. ## Contributing -Please read the [Contributing Guide](CONTRIBUTING.md) for details on the process for submitting pull requests to us. \ No newline at end of file +Please read the [Contributing Guide](CONTRIBUTING.md) for details on the process for submitting pull requests to us. From ba4d4285cc8c99cf002eb926f64f6766234ce49d Mon Sep 17 00:00:00 2001 From: Chris Archibald Date: Tue, 7 Nov 2023 18:24:23 +0000 Subject: [PATCH 2/4] Sync bitbucket and GitHub --- CODEOWNERS | 2 +- docs/data-sources/protocols_nfs_service_data_source.md | 2 +- docs/data-sources/storage_volume_snapshots_data_source.md | 2 +- docs/data-sources/svms_data_source.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index cc40c8c1..1dd32b02 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1 +1 @@ -* @carchi8py @chuyich @suhasbshekar @wenjun666 +* @carchi @chuyic @bsuhas @swenjun diff --git a/docs/data-sources/protocols_nfs_service_data_source.md b/docs/data-sources/protocols_nfs_service_data_source.md index e9a8dcef..3090ed27 100644 --- a/docs/data-sources/protocols_nfs_service_data_source.md +++ b/docs/data-sources/protocols_nfs_service_data_source.md @@ -1,5 +1,5 @@ --- -page_title: "ONTAP: NFS_Service " +page_title: "ONTAP: NFS_Service subcategory: "nas" description: |- Retrieves the NFS configuration of SVMs. diff --git a/docs/data-sources/storage_volume_snapshots_data_source.md b/docs/data-sources/storage_volume_snapshots_data_source.md index 3f61e50d..26fe0c4b 100644 --- a/docs/data-sources/storage_volume_snapshots_data_source.md +++ b/docs/data-sources/storage_volume_snapshots_data_source.md @@ -1,7 +1,7 @@ --- # generated by https://github.com/hashicorp/terraform-plugin-docs page_title: "netapp-ontap_storage_volume_snapshots_data_source Data Source - terraform-provider-netapp-ontap" -subcategory: "storage" +subcategory: "" description: |- Retrieves a collection of volume Snapshot copies --- diff --git a/docs/data-sources/svms_data_source.md b/docs/data-sources/svms_data_source.md index 552413be..6a116030 100644 --- a/docs/data-sources/svms_data_source.md +++ b/docs/data-sources/svms_data_source.md @@ -1,7 +1,7 @@ --- # generated by https://github.com/hashicorp/terraform-plugin-docs page_title: "netapp-ontap_svms_data_source Data Source - terraform-provider-netapp-ontap" -subcategory: "svm" +subcategory: "svms" description: |- Retrieves the configuration of SVMs. --- From 18f026a24b13175bc8ba4811dc3d815e80e1cf80 Mon Sep 17 00:00:00 2001 From: Chris Archibald Date: Tue, 7 Nov 2023 12:41:15 -0800 Subject: [PATCH 3/4] Bitbucket syncing was still enabled and delete some changes we made --- CHANGELOG.md | 2 +- CODEOWNERS | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c78186b1..af69ed28 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,4 @@ -## 1.0.0 (2023-09-18) +## 1.0.0 (2023-11-06) NOTES diff --git a/CODEOWNERS b/CODEOWNERS index 1dd32b02..9be6639d 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1 +1 @@ -* @carchi @chuyic @bsuhas @swenjun +* @carchi8py @chuyich @suhasbshekar @wenjun666 \ No newline at end of file From 2f734968863ea13bc9a5149c701e5ff1ac38abf0 Mon Sep 17 00:00:00 2001 From: Chuyi Ching Date: Wed, 8 Nov 2023 15:11:32 -0800 Subject: [PATCH 4/4] Fix documentation --- CHANGELOG.md | 6 ++++++ docs/data-sources/cluster_data_source.md | 9 +++++++-- docs/data-sources/snapmirrors_data_source.md | 2 +- docs/resources/networking_ip_route_resource.md | 2 +- docs/resources/storage_volume_resource.md | 12 ++++++------ 5 files changed, 21 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c78186b1..082ddb91 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ + +## 1.0.1 () + +BUG FIXES: +* netapp-ontap_cluster_data_source, netapp-ontap_snapmirrors_data_source, netapp-ontap_networking_ip_route_resource and netapp-ontap_sotrage_volume_resource: Fix documentation ([#70](https://github.com/NetApp/terraform-provider-netapp-ontap/issues/70)) + ## 1.0.0 (2023-09-18) NOTES diff --git a/docs/data-sources/cluster_data_source.md b/docs/data-sources/cluster_data_source.md index b1f77a9d..f69d860e 100644 --- a/docs/data-sources/cluster_data_source.md +++ b/docs/data-sources/cluster_data_source.md @@ -9,8 +9,13 @@ description: |- # netapp-ontap_cluster_data_source (Data Source) Cluster data source - - +## Example Usage +```terraform +data "netapp-ontap_cluster_data_source" "cluster" { + # required to know which system to interface with + cx_profile_name = "cluster2" +} +``` ## Schema diff --git a/docs/data-sources/snapmirrors_data_source.md b/docs/data-sources/snapmirrors_data_source.md index db49e736..b358e9b9 100644 --- a/docs/data-sources/snapmirrors_data_source.md +++ b/docs/data-sources/snapmirrors_data_source.md @@ -15,7 +15,7 @@ data "netapp-ontap_snapmirrors_data_source" "snapmirrors" { # required to know which system to interface with cx_profile_name = "cluster4" filter = { - "destination_path" = "snapmirror_dest_svm*" + destination_path = "snapmirror_dest_svm*" } } ``` diff --git a/docs/resources/networking_ip_route_resource.md b/docs/resources/networking_ip_route_resource.md index 4d3ebc5c..74eb561f 100644 --- a/docs/resources/networking_ip_route_resource.md +++ b/docs/resources/networking_ip_route_resource.md @@ -56,7 +56,7 @@ resource "netapp-ontap_networking_ip_route_resource" "networking_ip_route" { Optional: - `address` (String) IPv4 or IPv6 address -- `netmask` (String) netmask length (16) or IPv4 mask (255.255.0.0). For IPv6, valid range is 1 to 127. +- `netmask` (Number) netmask length (16) or IPv4 mask (255.255.0.0). For IPv6, valid range is 1 to 127. ## Import Import is currently not support for this Resource. diff --git a/docs/resources/storage_volume_resource.md b/docs/resources/storage_volume_resource.md index 73b01fc1..1039fe81 100644 --- a/docs/resources/storage_volume_resource.md +++ b/docs/resources/storage_volume_resource.md @@ -20,8 +20,8 @@ Create/modify/delete a Volume resource ```terraform resource "netapp-ontap_storage_volume_resource" "example" { cx_profile_name = "cluster5" - name = vol1 - svm_name = svm2 + name = "vol1" + svm_name = "svm2" aggregates = [ { name = "aggr2" @@ -34,9 +34,9 @@ resource "netapp-ontap_storage_volume_resource" "example" { type = "non_snaplock" } space = { - size = 30 - size_unit = "mb" - percent_snapshot_space = 20 + size = 30 + size_unit = "mb" + percent_snapshot_space = 20 logical_space = { enforcement = true reporting = true @@ -51,7 +51,7 @@ resource "netapp-ontap_storage_volume_resource" "example" { user_id = 20 unix_permissions = "755" security_style = "mixed" - junction_path = "/testacc" + junction_path = "/testacc" } } ```