Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure NetApp Files is hardcoded to use NFS v3 when creating Kubernetes / OpenShift volumes #334

Closed
nccurry opened this issue Jan 27, 2020 · 8 comments
Assignees
Labels

Comments

@nccurry
Copy link

nccurry commented Jan 27, 2020

When configuring trident against Azure NetApp Files the volumes created in Azure will always be NFS v3, regardless of whether or not the trident backend contains -o nfsvers=4 for nfsMountOptions.

It appears this is hardcoded in the NFSStorageDriver.Create() method here:
https://github.com/NetApp/trident/blob/master/storage_drivers/azure/azure_anf.go#L533

@gnarl
Copy link
Contributor

gnarl commented Feb 3, 2020

Unfortunately, Azure does not support NFS v4. Once Azure supports NFS v4 we will remove this hardcoded restriction from Trident.

@gnarl gnarl added the cvs label Feb 3, 2020
@gnarl gnarl self-assigned this Feb 3, 2020
@nccurry
Copy link
Author

nccurry commented Feb 3, 2020

@gnarl
Not sure if this is new or doesn't mean what I think it means.

https://docs.microsoft.com/en-us/azure/azure-netapp-files/azure-netapp-files-create-volumes

Azure NetApp Files supports NFS (NFSv3 and NFSv4.1) and SMBv3 volumes.

@gnarl
Copy link
Contributor

gnarl commented Feb 3, 2020

@nccurry, you're right. Thanks for pointing this out. It looks like it currently requires a whitelisting step according to this https://docs.microsoft.com/en-us/azure/azure-netapp-files/azure-netapp-files-faqs.

@gnarl gnarl added anf Azure NetApp Files enhancement tracked and removed cvs labels Feb 3, 2020
@paulomarquesc
Copy link

paulomarquesc commented Mar 6, 2020

Hi @gnarl, I'm from Azure NetApp Files team (MSFT side), NFSv4.1 is GA and does not require whitelisting anymore, can someone from your team make protocol types not hard coded anymore?As pointed out by @nccurry above it is hard coded.
If that helps, I recently published our ANF SDK sample for Go so you can take a look on how I'm creating NFSv4.1 volumes. Also, please let me know if you need my help on this to speed up fixing this issue since we have another customer in need for NFSv4.1 implemented on Trident.

@gnarl
Copy link
Contributor

gnarl commented Mar 6, 2020

Hi @paulomarquesc,

Our release schedule is every three months with the next release (20.04) being sometime in April. We will try to fit this change into the release schedule. Thanks for notifying us by updating the issue.

@gnarl
Copy link
Contributor

gnarl commented Mar 6, 2020

@paulomarquesc is Trident now able to set both NFSv3 and v4 at volume create time for ANF? This was previously a limitation that led us to hardcoding only support for NFSv3. I am @fchuck on thePub Slack if you want to contact me directly.

@paulomarquesc
Copy link

paulomarquesc commented Mar 6, 2020

@gnarl, ANF supports both (plus SMB), with NFSv4.1 being GA which means it does not need whitelisting anymore. Yes, I understand why it was hard-coded but now you can allow one of the protocols (not both at the same time on same volume). I just joined the Slack channel.

@clintonk
Copy link
Contributor

This was resolved in the 20.07.0 release. 6a4f3d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants