Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong ACK RUri #71

Open
ogolosovskiy opened this issue Nov 20, 2016 · 3 comments
Open

Wrong ACK RUri #71

ogolosovskiy opened this issue Nov 20, 2016 · 3 comments
Assignees

Comments

@ogolosovskiy
Copy link

ogolosovskiy commented Nov 20, 2016

ACK has wrong request Uri
The reason - different format for Record route options: <<"lr">> or {<<"lr">>,<<"on">>}
NKSIP Version v0.4.0

Quick fix -
-            case lists:member(<<"lr">>, RouteOpts) of
-                true ->     
-                    DestUri = TopRoute#uri{
+            Lr = lists:member(<<"lr">>, RouteOpts) or lists:member({<<"lr">>,<<"on">>}, RouteOpts),
+            case Lr of
+                true ->
+                  DestUri = TopRoute#uri{

@kalta
Copy link
Member

kalta commented Jan 14, 2019

What do you mean with <<"lr">>, <<"on">>?

@poroh
Copy link

poroh commented Mar 4, 2019

@kalta kalta self-assigned this Mar 5, 2019
@kalta
Copy link
Member

kalta commented Mar 5, 2019

Ok, I see now. I will fix that when I can go back yo nksip.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants