Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hystrix-metrics-event-stream implementation using JAX-RS instead of Servlet API #1490

Closed
justinjose28 opened this issue Mar 2, 2017 · 2 comments
Closed

hystrix-metrics-event-stream implementation using JAX-RS instead of Servlet API #1490

justinjose28 opened this issue Mar 2, 2017 · 2 comments
Labels
enhancement metrics

Comments

@justinjose28
Copy link

Right now, hystrix-metrics-event-stream module is dependent on Servlet API. But, I think there are applications that depend only on JAX-RS without any Servlet dependency. Does it make sense to add a module here based on JAX-RS which publishes metrics stream? It is fairly easy and I have created one for our application. I can contribute it if this is the right place to keep it.
@mattrjacobs
Copy link
Contributor

Sure, that does sound like a reasonable addition. I'm happy to review a PR for it. Thanks!

@justinjose28 justinjose28 mentioned this issue Mar 14, 2017
Merged
@justinjose28
Copy link
Author

@mattrjacobs I have opened a PRfor this issue. Can you please review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement metrics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattrjacobs @justinjose28