Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Collapser scope to REQUEST if using Setter #22

Closed
benjchristensen opened this issue Nov 29, 2012 · 2 comments
Closed

Default Collapser scope to REQUEST if using Setter #22

benjchristensen opened this issue Nov 29, 2012 · 2 comments
Milestone
1.0.x

Comments

@benjchristensen
Copy link
Contributor

The default is set to REQUEST via the constructor, but it someone uses the Setter fluent interface it doesn't get defaulted.
@benjchristensen
Copy link
Contributor Author

This isn't causing anything to fail because there is a fallback in queue() to use REQUEST if scope is null, but that safety-net shouldn't be relied upon here.

@benjchristensen benjchristensen mentioned this issue Nov 29, 2012
Merged
@benjchristensen
Copy link
Contributor Author

Committed in 38d85c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.x
Development

No branches or pull requests
1 participant
@benjchristensen