Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more info when collapsed requests remain in queue #78

Closed
daveray opened this issue Jan 8, 2013 · 3 comments
Closed

Include more info when collapsed requests remain in queue #78

daveray opened this issue Jan 8, 2013 · 3 comments
Milestone

Comments

@daveray
Copy link
Contributor

daveray commented Jan 8, 2013

When a collapser is shutdown and requests remain in the queue a warning message is logged. Include more details about the remaining requests (class, etc, etc) to assist in debugging.

@ghost ghost assigned benjchristensen Jan 8, 2013
@benjchristensen
Copy link
Contributor

A new WARN message will be logged as:

"Request still in queue but not be executed due to RequestCollapser shutdown. Argument => " + request.getArgument() + " Request Object => " + request, new IllegalStateException()

@benjchristensen
Copy link
Contributor

Merged into master.

I have one more small change I want to add before release 1.2.1 but will do so within the next couple hours so you can get this build into your environment for debugging.

@daveray
Copy link
Contributor Author

daveray commented Jan 8, 2013

This output was very helpful. I think I might have an idea what's going on now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants