Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mispelled and unknown words are difficult to read with Dark and System themes #1792

Open
1 task
TraceyC77 opened this issue Aug 12, 2024 · 0 comments
Open
1 task
Labels
bug Something isn't working

Comments

@TraceyC77
Copy link

Describe the bug

In a recent update, Nheko began automatically highlighting misspelled / unknown words (technical terms, words in another language etc)
The low contrast this text has in the Dark & System Nheko themes makes any affected text hard to read.
This is an accessibility issue.

Additionally, words are highlighted as misspelled before the user is finished typing them, which makes this more of an issue.

There isn't a setting to disable spellcheck, so there is no ability for the user to work around this except to use the Light theme.

This relates to an old feature request /issues/174
Just underlining misspelled / not yet complete / unknown words would be more readable than making the text red on a red background.

To Reproduce

  1. Set Nheko to use the Dark theme or use System, with the system theme set to a dark theme.
  2. Start typing in the input area. Stop before you complete a word or misspell a word to trigger the spell check

Note that with my settings, the input area when using System (dark grey) is darker than Dark (medium grey)
I've attached screenshots using both themes

What happened?

The text is red, with a red underline and a translucent red background against the grey input area.
The misspelled word is difficult to read, due to low contrast between colors. Regular text is easy to read.
Spellcheck errors are triggered on words that are still being typed.

Expected behavior

Misspelled / unknown words are as easy to read as default text
Spell check is not triggered until a space is typed, indicating the word is done being entered

Screenshots

Dark theme
nheko_dark_spellcheck_20240812_104023

System theme
nheko_system_spellcheck_20240812_104023

Version

0.12.0

Operating system

Linux

Installation method

Some repository (AUR, homebrew, distribution repository, PPA, etc)

Qt version

6.7.2

C++ compiler

No response

Desktop Environment

KDE Plasma

Did you use profiles?

  • Profiles used?

Relevant log output

No response

Backtrace

No response

@TraceyC77 TraceyC77 added the bug Something isn't working label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant