Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: host_machine.system() isn't our SYSTEM #10957

Open
roberth opened this issue Jun 25, 2024 · 1 comment
Open

meson: host_machine.system() isn't our SYSTEM #10957

roberth opened this issue Jun 25, 2024 · 1 comment
Labels
bug build-problem Nix fails to compile or test; also improvements to build process store Issues and pull requests concerning the Nix store

Comments

@roberth
Copy link
Member

roberth commented Jun 25, 2024

Originally posted in #10908 (comment)

This is probably wrong. host_machine.system() is expected to have e.g. 'linux' in other places.

I don't know how to get the right value, reliably, and we've defined it to be based on autoconf, which I don't think we want to continue doing, or do we? Alternatively, we could leave it to the packager, and pass stdenv.hostPlatform.system in our own packaging?

@roberth roberth added bug build-problem Nix fails to compile or test; also improvements to build process store Issues and pull requests concerning the Nix store labels Jun 25, 2024
@Ericson2314
Copy link
Member

Ericson2314 commented Aug 28, 2024

We now have

configdata.set_quoted('SYSTEM', host_machine.cpu_family() + '-' + host_machine.system())

which is correct / a lot closer to being correct.

See https://mesonbuild.com/Reference-tables.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build-problem Nix fails to compile or test; also improvements to build process store Issues and pull requests concerning the Nix store
Projects
None yet
Development

No branches or pull requests

2 participants