Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating multiple packages (with CPM and transitive pinning) should verify the referenced versions afterwards #13793

Open
keldaaas opened this issue Sep 19, 2024 · 1 comment
Labels
Functionality:VisualStudioUI Product:VS.Client Triage:NeedsMoreInfo Type:DCR Design Change Request WaitingForCustomer Applied when a NuGet triage person needs more info from the OP

Comments

@keldaaas
Copy link

keldaaas commented Sep 19, 2024

NuGet Product(s) Affected

Visual Studio Package Management UI

Current Behavior

With CPM and transitive pinning enabled:

Solution S contains a console app and a test project.
The console app references package A.
The test project references package B.
Package B has a dependency on package A.

ConsoleApp -> Package A
TestProject -> Package B -> Package A

Whenever one tries to update both packages at the same time with the Package Manager UI there is an error NU1109. I suppose this happens because the check for package B's dependencies doesn't take into account that package A will be updated as well. Instead it stops this process to avoid referencing different versions of package A.
At the moment the only solution is to update package A first and package B afterwards. This makes the CPM really annoying to use in solutions with a lot of dependencies.

Desired Behavior

Either take into account that a referenced transitive dependency gets updated "at the same time" or check for different versions after the updates were executed.

Additional Context

dotnet outdated updates the packages as expected.

@keldaaas keldaaas added Triage:Untriaged Type:DCR Design Change Request labels Sep 19, 2024
@NuGet NuGet deleted a comment Sep 19, 2024
@jgonz120
Copy link

Hello, I haven't been able to reproduce this behavior, when I try to update all packages in the PM UI it updates successfully. Can you provide an example project that reproduces this?

@jgonz120 jgonz120 added Product:VS.Client Functionality:VisualStudioUI WaitingForCustomer Applied when a NuGet triage person needs more info from the OP Triage:NeedsMoreInfo and removed Triage:Untriaged labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:VisualStudioUI Product:VS.Client Triage:NeedsMoreInfo Type:DCR Design Change Request WaitingForCustomer Applied when a NuGet triage person needs more info from the OP
Projects
None yet
Development

No branches or pull requests

2 participants