Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet doesn't install split localized packages in PackageReference #2245

Open
ericstj opened this issue Mar 3, 2016 · 3 comments
Open

NuGet doesn't install split localized packages in PackageReference #2245

ericstj opened this issue Mar 3, 2016 · 3 comments
Labels
Functionality:Restore Platform:Xplat Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Triage:NeedsDesignSpec Type:Feature
Milestone

Comments

@ericstj
Copy link

ericstj commented Mar 3, 2016

Repro:
Create a .NET 4.5 project and install "Microsoft.AspNet.Mvc": "5.2.3".
Now try to install "Microsoft.AspNet.Mvc.de": "5.2.3"

Expect:
Install success and localized bits are overlayed on the primary package.

Actual:
Install failure.

Microsoft.AspNet.Mvc.de 5.2.3 is not compatible with .NETFramework,Version=v4.5.

This worked with a net45 project using packages.config.

I'm looking into this in an effort to see what can be done to reduce package size of CoreFx.

current doc link: https://docs.microsoft.com/en-us/nuget/create-packages/creating-localized-packages

@yishaigalatzer
Copy link

I don't think we want to go with this approach, this model was never adopted by the community,and with this we are changing the content of a package in a global folder, which is violating the basic principle of content of a package is the same given its id and version.

I think we want to go back and discuss the loading model for localized assets (which we can probably do in .NET), and the XML documentation in visual studio.

So this needs to reopen the discussion we had last time with VS.

I do agree that you should be able to install the localized package as is, in its own folder (if of course we can find a way to make it usable).

So to summarize we have a few options:

  1. Declare these packages not supported
  2. Allow these packages to restore, but put them in their own folder and make .net load them from the right place, and make vs support a different from of xml intellisense (through the redirect)
  3. Do the hacky thing NuGet did with packages.config
  4. Make the default .NET install not bring down anything but English for RC, and work on a plan for RTM.

CC @lodejard @davidfowl

@rrelyea rrelyea added CLI RTM and removed CLI RC2 labels Mar 29, 2016
@emgarten emgarten removed their assignment Feb 14, 2017
@rrelyea rrelyea changed the title NuGet doesn't install split localized packages in project.json NuGet doesn't install split localized packages in packagereferences Nov 29, 2017
@rrelyea rrelyea added this to the Backlog milestone Nov 29, 2017
@rrelyea rrelyea added the Priority:2 Issues for the current backlog. label Nov 29, 2017
@rrelyea
Copy link
Contributor

rrelyea commented Nov 29, 2017

@mishra14 -- you said you knew a dupe?

@nkolev92 nkolev92 removed the CLI RTM label Jan 6, 2020
@aortiz-msft aortiz-msft added the Category:Quality Week Issues that should be considered for quality week label Feb 21, 2020
@nkolev92
Copy link
Member

I'm not sure the design is clear cut here. Adding more labels to indicate the status and moving back to New Issues for retriaging.

@nkolev92 nkolev92 added Pipeline:Icebox Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. and removed Pipeline:Backlog Priority:2 Issues for the current backlog. Triage:NeedsTriageDiscussion labels Oct 22, 2020
@dominoFire dominoFire changed the title NuGet doesn't install split localized packages in packagereferences NuGet doesn't install split localized packages in PackageReference Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Restore Platform:Xplat Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Triage:NeedsDesignSpec Type:Feature
Projects
None yet
Development

No branches or pull requests

9 participants