[FIX] restore_registry in Odoo 16 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanRijnhart
force-pushed
the
fix/16.0/base_classes_attribute
branch
from
737d8f5
to
ec1a87f
Compare
StefanRijnhart
force-pushed
the
fix/16.0/base_classes_attribute
branch
3 times, most recently
from
8bafdff
to
a9ee140
Compare
StefanRijnhart
force-pushed
the
fix/16.0/base_classes_attribute
branch
from
a9ee140
to
e3e662b
Compare
rousseldenis
approved these changes
Feb 8, 2023
|
I can confirm this solves problems like OCA/stock-logistics-barcode#450 |
|
@OCA/core-maintainers |
pedrobaeza
approved these changes
Feb 8, 2023
hbrunn
approved these changes
Feb 8, 2023
|
Sorry to be late to the party. I'm sick and missed this change 😓 |
|
@simahawk take care! |
|
@StefanRijnhart Could you check this as it seems to fail now: https://github.com/OCA/stock-logistics-workflow/actions/runs/4132016101/jobs/7140224436#step:8:244 |
|
It seems that this line is causing trouble:
I'm wondering how if an attribute exists in a model, the following line that tries to delete it fails on retrieving it... |
|
Thanks for noting, I'll have a look. |
|
@rousseldenis #24 should fix it, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See odoo/odoo@cd12293
This new attribute is the source of truth for the base classes, and in setup_models (called further down in the modified code in this PR), the model's base classes are reset from it: https://github.com/odoo/odoo/blob/e1f06479a526c703ccabc441b1e194646206b966/odoo/models.py#L2728-L2730.
The test failure fixed by this PR can be inspected in https://app.travis-ci.com/github/OCA/odoo-test-helper/builds/258453331