[MIG][16.0] partner_industry_parent #1835
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (14 of 14 strings) Translation: partner-contact-15.0/partner-contact-15.0-partner_industry_parent Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_industry_parent/es/
gdgellatly
reviewed
Aug 29, 2024
| _inherit = "res.partner" | ||
|
|
||
| @api.model | ||
| def _search( |
There was a problem hiding this comment.
This is just a minor point, I know you didn't write yourself, and purely opinion. I much prefer these overrides where only args is amended to use the idiom
def _search(args, **kwargs):
# modify args code
return super()._search(args, **kwargs)It is loads shorter, more resistant to api changes, and cleaner for people to read as they know only args is being affected.
Then super()
| @api.model | ||
| def view_header_get(self, view_id, view_type): | ||
| if self._context.get("industry_id"): | ||
| return _( |
There was a problem hiding this comment.
Is this right? I don't really know translations but I thought the rule was _(<format_string>), args not _(<format_string>, args)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.