Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] product_multi_barcode: fix muti-company access right issue #501

Merged
merged 1 commit into from
Apr 4, 2023
Merged

[14.0] product_multi_barcode: fix muti-company access right issue #501

merged 1 commit into from
Apr 4, 2023

Conversation

sebastienbeau
Copy link
Member

@sebastienbeau sebastienbeau commented Feb 23, 2023 •
edited
Loading

Context
In multi company

  • add a barcode in company A (for a product that belong to company A)
  • then add the same barcode in company B (for a product that belong to company B)

=> you have a access error message instead of a the error message that give the information of the duplicated product barcode.

@sebastienbeau
Copy link
Member Author

@Kev-Roche

Kev-Roche
Kev-Roche approved these changes Feb 23, 2023
View reviewed changes
Copy link

@Kev-Roche Kev-Roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StefanRijnhart StefanRijnhart mentioned this pull request Apr 4, 2023
Merged
@StefanRijnhart StefanRijnhart changed the title product_multi_barcode: fix muti-company access right issue [14.0] product_multi_barcode: fix muti-company access right issue Apr 4, 2023
@StefanRijnhart StefanRijnhart added this to the 14.0 milestone Apr 4, 2023
@rvalyi
Copy link
Member

rvalyi commented Apr 4, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-501-by-rvalyi-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a7cdb68 into OCA:14.0 Apr 4, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8fe8e70. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@Kev-Roche Kev-Roche Kev-Roche approved these changes

@aliciagaarzo aliciagaarzo aliciagaarzo approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@sebastienbeau @OCA-git-bot @rvalyi @StefanRijnhart @rousseldenis @Kev-Roche @aliciagaarzo