-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blinky Example doesn't compile due to lack of LL Components #241
Comments
Thank you for reporting this issue. Please do the PR as it will be easier to look at the diffs. |
Ok I see what you mean. We will need to be able to reproduce the issue first. |
Using cmake 3.13.3 in terminal. I just tested with cmake 3.19.2 that comes bundled with CLion and the issue does not occur. HAL is STM32F4 (default). Blinky was not modified. |
This looks like a change in behavior introduced in CMake 3.14: Release Notes, search for |
Well done. I just found same reference and wanted to share link. |
All tests are run an ubuntu 20.04 so after discussion with @Hish15 we will bump minium cmake version to 3.16. |
Makes sense. Ubuntu 18.04 is actually CMake 3.10. According to this table, Pinning at 3.13 really only adds Debian Buster. |
Yes moreover if people were really using 3.13 you should not have been the first person to mention the problem. So I suppose it won't hurt too much. |
Describe the bug
When attempting to build the
blinky
example I receive the following error.I presume that the lack of LL drivers in the blinky example causes
list(REMOVE_DUPLICATES HAL_FIND_COMPONENTS_DRIVERS_LL)
to fail.I commented out the code as a test and then attempted to build blinky-ll and ran into similar errors related to
HAL_FIND_COMPONENTS_DRIVERS
.I modified FindHAL.cmake to have checks surrounding the relevant blocks as below and all examples built correctly.
If this is a correct / desirable change I'm happy to create a pull request.
see #242
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: