From 1aebb1b6d2553e99ca1997210351465797df96b2 Mon Sep 17 00:00:00 2001 From: Kaloyan Tanev <24719519+KaloyanTanev@users.noreply.github.com> Date: Tue, 10 Sep 2024 15:37:01 +0200 Subject: [PATCH] cmd: increase testpeers tests timeouts (#3268) Fixing flaky test in previous PR #3267 revealed another issue. Fixing that one, which is purely unit test related. category: test ticket: none --- cmd/testpeers_internal_test.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/cmd/testpeers_internal_test.go b/cmd/testpeers_internal_test.go index 34051717d..1d9fb8e4a 100644 --- a/cmd/testpeers_internal_test.go +++ b/cmd/testpeers_internal_test.go @@ -121,7 +121,7 @@ func TestPeersTest(t *testing.T) { OutputToml: "", Quiet: true, TestCases: nil, - Timeout: time.Second, + Timeout: 3 * time.Second, }, ENRs: []string{ "enr:-HW4QBHlcyD3fYWUMADiOv4OxODaL5wJG0a7P7d_ltu4VZe1MibZ1N-twFaoaq0BoCtXcY71etxLJGeEZT5p3XCO6GOAgmlkgnY0iXNlY3AyNTZrMaEDI2HRUlVBag__njkOWEEQRLlC9ylIVCrIXOuNBSlrx6o", @@ -188,7 +188,7 @@ func TestPeersTest(t *testing.T) { OutputToml: "", Quiet: false, TestCases: []string{"ping"}, - Timeout: time.Second, + Timeout: 200 * time.Millisecond, }, ENRs: []string{ "enr:-HW4QBHlcyD3fYWUMADiOv4OxODaL5wJG0a7P7d_ltu4VZe1MibZ1N-twFaoaq0BoCtXcY71etxLJGeEZT5p3XCO6GOAgmlkgnY0iXNlY3AyNTZrMaEDI2HRUlVBag__njkOWEEQRLlC9ylIVCrIXOuNBSlrx6o", @@ -224,7 +224,7 @@ func TestPeersTest(t *testing.T) { testConfig: testConfig{ OutputToml: "./write-to-file-test.toml.tmp", Quiet: false, - Timeout: 500 * time.Millisecond, + Timeout: 3 * time.Second, }, ENRs: []string{ "enr:-HW4QBHlcyD3fYWUMADiOv4OxODaL5wJG0a7P7d_ltu4VZe1MibZ1N-twFaoaq0BoCtXcY71etxLJGeEZT5p3XCO6GOAgmlkgnY0iXNlY3AyNTZrMaEDI2HRUlVBag__njkOWEEQRLlC9ylIVCrIXOuNBSlrx6o", @@ -241,10 +241,11 @@ func TestPeersTest(t *testing.T) { CategoryName: peersTestCategory, Targets: map[string][]testResult{ "self": { - {Name: "libp2pTCPPortOpenTest", Verdict: testVerdictFail, Measurement: "", Suggestion: "", Error: errTimeoutInterrupted}, + {Name: "libp2pTCPPortOpenTest", Verdict: testVerdictOk, Measurement: "", Suggestion: "", Error: testResultError{}}, }, fmt.Sprintf("relay %v", relayAddr): { - {Name: "pingRelay", Verdict: testVerdictFail, Measurement: "", Suggestion: "", Error: errTimeoutInterrupted}, + {Name: "pingRelay", Verdict: testVerdictOk, Measurement: "", Suggestion: "", Error: testResultError{}}, + {Name: "pingMeasureRelay", Verdict: testVerdictGood, Measurement: "", Suggestion: "", Error: testResultError{}}, }, "peer inexpensive-farm enr:-HW4QBHlcyD3fYWUMADiOv4OxODaL5wJG0a7P7d_ltu4VZe1MibZ1N-twFaoaq0BoCtXcY71etxLJGeEZT5p3XCO6GOAgmlkgnY0iXNlY3AyNTZrMaEDI2HRUlVBag__njkOWEEQRLlC9ylIVCrIXOuNBSlrx6o": { {Name: "ping", Verdict: testVerdictFail, Measurement: "", Suggestion: "", Error: errTimeoutInterrupted},