Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil/promrated: update promrated querying #2844

Merged
merged 7 commits into from
Feb 1, 2024

Conversation

LukeHackett12
Copy link
Contributor

Promrated is needed to fulfill a slightly different purpose these days, refactoring to reflect that and adding a needed endpoint.

category: refactor
ticket: #2843

@LukeHackett12 LukeHackett12 changed the title testutil/promrated: Update promrated querying testutil/promrated: update promrated querying Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (3e12d09) 53.46% compared to head (dc964f7) 53.50%.
Report is 1 commits behind head on main.

Files Patch % Lines
testutil/promrated/promrated.go 0.00% 23 Missing ⚠️
testutil/promrated/rated.go 76.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2844      +/-   ##
==========================================
+ Coverage   53.46%   53.50%   +0.04%     
==========================================
  Files         200      200              
  Lines       28037    28011      -26     
==========================================
- Hits        14989    14987       -2     
+ Misses      11187    11166      -21     
+ Partials     1861     1858       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit
Copy link
Contributor

pinebit commented Jan 31, 2024

Pay attention to linter issues:

  Error: const `promQuery` is unused (unused)
  Error: type `validator` is unused (unused)
  Error: func `getValidators` is unused (unused)
  Error: func `parseValidators` is unused (unused)

You can run pre-commit locally to see them before committing to save time.

@LukeHackett12
Copy link
Contributor Author

pre commit passed locally 😞 , think it should be fixed now!

Copy link
Contributor

@pinebit pinebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the copy-paste error
flags.StringSliceVar(&config.Networks, "node-operators", nil, "Comma separated list of one or node operators to monitor.")

Copy link
Contributor

@pinebit pinebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get at least one more approval from Protocol.

testutil/promrated/promrated.go Show resolved Hide resolved
testutil/promrated/rated.go Outdated Show resolved Hide resolved
testutil/promrated/rated.go Show resolved Hide resolved
testutil/promrated/rated_internal_test.go Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@LukeHackett12 LukeHackett12 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Feb 1, 2024
@obol-bulldozer obol-bulldozer bot merged commit cfe844b into main Feb 1, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the luke/promrated-update branch February 1, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants