Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R08 : New entries - SOLOBGC, PROVOR III and V #69

Closed
vturpin opened this issue Sep 25, 2023 · 6 comments
Closed

R08 : New entries - SOLOBGC, PROVOR III and V #69

vturpin opened this issue Sep 25, 2023 · 6 comments
Labels
avtt Argo Vocabulary Task Team R08

Comments

@vturpin
Copy link

vturpin commented Sep 25, 2023

New addition to the CCT C-3 have been requested, see status of: wmo-im/CCT#134

884 - "SOLO_BGC, SBE"
885 - " SOLO_BGC, RBR"
886 - "SOLO_BGC_MRV, SBE"
887 - "SOLO_BGC_MRV, RBR"

888 - "PROVOR_V - Jumbo, SBE"
889 - "PROVOR_V - Jumbo, RBR"
890 - "PROVOR_III - Jumbo, SBE"
891 - "PROVOR_III - Jumbo, RBR"

Those 8 entries should be added to R08 too.

@tcarval
Copy link
Contributor

tcarval commented Sep 25, 2023

@gmaze
Copy link
Member

gmaze commented Oct 2, 2023

weird: "PROVOR_III" seems to have disappeared from R08 as 836 ?

in fact, looks like:
834 | PROVOR V SBE
835 | PROVOR IV
836 | PROVOR III

have been removed. should these be "deprecated" instead of removed ?

@tcarval
Copy link
Contributor

tcarval commented Oct 3, 2023

@gmaze, thank you Guillaume for spotting that.
These 834, 835 and 836 floats are perfectly valid, but do not appear in the NVS.
@vpaba, Violetta is there a reason for that ?
I just submitted these 3 definitions in the R08 table.
They should appear soon.

@vpaba
Copy link
Contributor

vpaba commented Oct 3, 2023

Hi @tcarval, Thanks for this - I checked R08 and there was no record of 834, 835 and 836 on our side, which is strange! It could be that they were never created, because otherwise we'd expect them to see them as deprecated at most, like mentioned above. Are these three codes already present in CCT C-3 @vturpin ?
We've received these new submissions and they have been approved, so they should appear on the NVS tomorrow.

One thing I noticed, the last few submissions (890, 891, 889, 881, 882, 884, 885, 886, 887, 888, 834, 835, 836) don't have an 'alternative label' / CODVAL specified (which had been the same as the Identifier for R08) - would you like me to update this so that it's consistent with the rest of the list, or is it no longer necessary?

Thank you,
Violetta

@vturpin
Copy link
Author

vturpin commented Oct 4, 2023

Yes 834, 835 and 836 are already in the CCT C-3.
I found it here: wmo-im/CCT@5f23405#diff-80cdc2d7308f541a438e53cecec1bd0143e158d7a675ab60655150804426e78c

@tcarval
Copy link
Contributor

tcarval commented Oct 22, 2023

Hi @tcarval, Thanks for this - I checked R08 and there was no record of 834, 835 and 836 on our side, which is strange! It could be that they were never created, because otherwise we'd expect them to see them as deprecated at most, like mentioned above. Are these three codes already present in CCT C-3 @vturpin ? We've received these new submissions and they have been approved, so they should appear on the NVS tomorrow.

One thing I noticed, the last few submissions (890, 891, 889, 881, 882, 884, 885, 886, 887, 888, 834, 835, 836) don't have an 'alternative label' / CODVAL specified (which had been the same as the Identifier for R08) - would you like me to update this so that it's consistent with the rest of the list, or is it no longer necessary?

Thank you, Violetta

Yes please add 'alternative label' / CODVAL to be consistent

@vpaba vpaba added avtt Argo Vocabulary Task Team R08 labels Apr 19, 2024
@vpaba vpaba closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
avtt Argo Vocabulary Task Team R08
Projects
None yet
Development

No branches or pull requests

4 participants