Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about invalid apply_dimensions callbacks #554

Open
soxofaan opened this issue Oct 27, 2023 · 0 comments
Open

Warn about invalid apply_dimensions callbacks #554

soxofaan opened this issue Oct 27, 2023 · 0 comments

Comments

@soxofaan
Copy link
Member

from Open-EO/openeo-processes#471 (comment):

{
  "apply1": {
    "process_id": "apply_dimension"
    "arguments": {
      "data": {"from_node": "load1"},
      "dimension": "t",
      "process": {
        "process_graph": {
          "max1": {
            "arguments": {"data": {"from_parameter": "data"}},
            "process_id": "max",
            "result": true
          }
        }
      }
    },
  }

This is invalid openEO process graph: process arg in apply_dimension should be a callback that takes an array and returns an array, but here (max) it is a callback that takes an array and returns a scalar.

VITO backend still accepts this, probably by automatically wrapping the scalar in an array.
Keeping this behavior is fine for now I guess, but at least we should log a warning about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant