Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User and Post Services: Replace Exec() with ExecContext() #122

Open
2 tasks
codegold79 opened this issue Feb 17, 2021 · 1 comment
Open
2 tasks

User and Post Services: Replace Exec() with ExecContext() #122

codegold79 opened this issue Feb 17, 2021 · 1 comment
Labels
end: back note: good first good first issue to consider taking note: help wanted

Comments

@codegold79
Copy link
Collaborator

codegold79 commented Feb 17, 2021

In the qryuser.go and qrypost.go files, the Exec() methods should be replaced with ExecContext(). The reason for this is to be able to take advantage of the the cancellation/timeout that contexts can initiate.

See an example of ExecContext() in the upsertUser method in qryuser.go.

A/C

  • Replace Exec() with ExecContext() in the user and post service queries
  • Ensure the artefact tests pass after the changes
@codegold79 codegold79 added end: back note: good first good first issue to consider taking note: help wanted labels Feb 17, 2021
@daved
Copy link
Member

daved commented Jul 27, 2023

Sure, sounds good. I think the main takeaway will be having the project building and tests running. I expect I'll have a story or two blocking (probably the actions bot issue, at least).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
end: back note: good first good first issue to consider taking note: help wanted
Projects
None yet
Development

No branches or pull requests

2 participants