Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment.yml #39

Merged
merged 14 commits into from
May 8, 2024
Merged

Update environment.yml #39

merged 14 commits into from
May 8, 2024

Conversation

richardjgowers
Copy link
Contributor

I think moving gufe from a pip build from branch to a conda dep might then install all dependencies (e.g. openff-units)

@pep8speaks
Copy link

pep8speaks commented May 7, 2024

Hello @richardjgowers! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 142:52: E252 missing whitespace around parameter equals
Line 142:53: E252 missing whitespace around parameter equals
Line 163:80: E501 line too long (80 > 79 characters)
Line 164:80: E501 line too long (80 > 79 characters)

Line 15:80: E501 line too long (101 > 79 characters)

Line 15:80: E501 line too long (96 > 79 characters)

Line 14:80: E501 line too long (96 > 79 characters)

Line 12:80: E501 line too long (94 > 79 characters)

Line 19:80: E501 line too long (88 > 79 characters)
Line 32:51: E251 unexpected spaces around keyword / parameter equals
Line 32:53: E251 unexpected spaces around keyword / parameter equals
Line 153:24: E251 unexpected spaces around keyword / parameter equals
Line 153:26: E251 unexpected spaces around keyword / parameter equals

Line 54:80: E501 line too long (85 > 79 characters)
Line 55:80: E501 line too long (103 > 79 characters)
Line 56:80: E501 line too long (96 > 79 characters)
Line 59:80: E501 line too long (88 > 79 characters)
Line 63:80: E501 line too long (97 > 79 characters)

Line 40:80: E501 line too long (94 > 79 characters)

Comment last updated at 2024-05-08 11:07:18 UTC

richardjgowers and others added 2 commits May 7, 2024 11:18
will still ducktype fine

this isn't in a released gufe, so can't use (yet)
Copy link

codecov bot commented May 8, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@richardjgowers richardjgowers merged commit bd8f16c into main May 8, 2024
6 checks passed
@richardjgowers richardjgowers deleted the fix_CI branch May 8, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants