Unittests network tool & Concatenator refactor

[RiesBen]

adding unit test coverage to network_tools and concatenator Refactor

[pep8speaks]

Hello @RiesBen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file src/konnektor/network_planners/concatenator/_abstract_network_concatenator.py:

Line 66:9: E125 continuation line with same indent as next logical line

• In the file src/konnektor/network_planners/concatenator/cyclic_concatenator.py:

Line 51:9: E125 continuation line with same indent as next logical line

• In the file src/konnektor/network_planners/concatenator/max_concatenator.py:

Line 43:9: E125 continuation line with same indent as next logical line

• In the file src/konnektor/network_planners/concatenator/mst_concatenator.py:

Line 45:9: E125 continuation line with same indent as next logical line

• In the file src/konnektor/network_tools/concatenate.py:

Line 56:80: E501 line too long (84 > 79 characters)

• In the file src/konnektor/network_tools/merge.py:

Line 66:11: E271 multiple spaces after keyword
Line 67:64: E202 whitespace before ')'

• In the file src/konnektor/network_tools/misc.py:

Line 29:5: E731 do not assign a lambda expression, use a def

• In the file src/konnektor/tests/network_planners/test_bipartite_MST_connector.py:

Line 30:32: W292 no newline at end of file

• In the file src/konnektor/tests/network_planners/test_bipartite_max_concatenator.py:

Line 7:80: E501 line too long (83 > 79 characters)
Line 9:80: E501 line too long (100 > 79 characters)
Line 12:1: E265 block comment should start with '# '
Line 26:46: W292 no newline at end of file

• In the file src/konnektor/tests/network_tools/test_clustering.py:

Line 5:80: E501 line too long (80 > 79 characters)

• In the file src/konnektor/tests/network_tools/test_concatenate.py:

Line 17:80: E501 line too long (81 > 79 characters)
Line 49:80: E501 line too long (91 > 79 characters)

• In the file src/konnektor/tests/network_tools/test_misc.py:

Line 2:80: E501 line too long (80 > 79 characters)

• In the file src/konnektor/tests/test_toy_data.py:

Line 6:80: E501 line too long (82 > 79 characters)
Line 112:80: E501 line too long (104 > 79 characters)
Line 114:80: E501 line too long (80 > 79 characters)

• In the file src/konnektor/utils/toy_data.py:

Line 102:80: E501 line too long (80 > 79 characters)
Line 149:5: E125 continuation line with same indent as next logical line
Line 192:80: E501 line too long (83 > 79 characters)

Comment last updated at 2024-05-10 12:26:22 UTC

[codecov]

Codecov Report

Attention: Patch coverage is 94.71947% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 76.14%. Comparing base (bd8f16c) to head (a7329be).

Files	Patch %	Lines
...twork_planners/concatenator/cyclic_concatenator.py	0.00%	9 Missing ⚠️
src/konnektor/network_tools/misc.py	89.47%	2 Missing ⚠️
src/konnektor/tests/test_toy_data.py	92.30%	2 Missing ⚠️
...ers/generators/two_dimensional_network_planners.py	50.00%	1 Missing ⚠️
src/konnektor/network_tools/merge.py	87.50%	1 Missing ⚠️
src/konnektor/utils/toy_data.py	96.29%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   71.75%   76.14%   +4.38%     
==========================================
  Files          58       64       +6     
  Lines        1703     1899     +196     
==========================================
+ Hits         1222     1446     +224     
+ Misses        481      453      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.