Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other intermediate generator to wrapper #57

Conversation

LindeSchoenmaker
Copy link

No description provided.

@pep8speaks
Copy link

Hello @LindeSchoenmaker! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 20:80: E501 line too long (84 > 79 characters)
Line 23:41: W291 trailing whitespace
Line 25:80: E501 line too long (96 > 79 characters)
Line 30:80: E501 line too long (107 > 79 characters)
Line 34:80: E501 line too long (94 > 79 characters)
Line 36:1: W293 blank line contains whitespace
Line 46:80: E501 line too long (94 > 79 characters)
Line 47:1: W293 blank line contains whitespace
Line 48:1: E302 expected 2 blank lines, found 1
Line 122:80: E501 line too long (94 > 79 characters)

Copy link
Contributor

@RiesBen RiesBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :) I will do minor refactors for the konnektor repo, but appart from that perfect! :)

@RiesBen RiesBen merged commit 8a5c602 into OpenFreeEnergy:intermediate_generator Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants