Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI #81

Merged
merged 5 commits into from
Sep 18, 2024
Merged

fix CI #81

merged 5 commits into from
Sep 18, 2024

Conversation

RiesBen
Copy link
Contributor

@RiesBen RiesBen commented Sep 18, 2024

trying to solve the macos fails in CI

@RiesBen RiesBen self-assigned this Sep 18, 2024
@RiesBen RiesBen linked an issue Sep 18, 2024 that may be closed by this pull request
@RiesBen RiesBen mentioned this pull request Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes missing coverage. Please review.

Project coverage is 86.81%. Comparing base (199903d) to head (9841cfd).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...network_planners/concatenators/max_concatenator.py 73.52% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   87.11%   86.81%   -0.31%     
==========================================
  Files          49       49              
  Lines        1545     1577      +32     
==========================================
+ Hits         1346     1369      +23     
- Misses        199      208       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pep8speaks
Copy link

pep8speaks commented Sep 18, 2024

Hello @RiesBen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 101:80: E501 line too long (82 > 79 characters)
Line 104:21: E731 do not assign a lambda expression, use a def
Line 115:80: E501 line too long (83 > 79 characters)
Line 116:25: E722 do not use bare 'except'
Line 129:80: E501 line too long (86 > 79 characters)
Line 133:80: E501 line too long (86 > 79 characters)
Line 136:80: E501 line too long (86 > 79 characters)
Line 141:29: E722 do not use bare 'except'

Comment last updated at 2024-09-18 07:44:11 UTC

adding parallel bi-cat test.
@RiesBen RiesBen merged commit 540ed94 into main Sep 18, 2024
4 of 6 checks passed
@RiesBen RiesBen deleted the fixCI branch September 18, 2024 08:22
@RiesBen RiesBen changed the title [WIP] - fix CI fix CI Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ci Fail for macOS
2 participants