Fixed deprecation warning in Mage_Downloadable_Helper_Catalog_Product…

…_Configuration (#3187)
OpenMage · Apr 18, 2023 · 3501e73 · 3501e73
1 parent 4ade428
commit 3501e73
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/app/code/core/Mage/Catalog/Model/Product.php b/app/code/core/Mage/Catalog/Model/Product.php
@@ -127,7 +127,6 @@
  * @method $this setLinksExist(bool $value)
  * @method bool getLinksPurchasedSeparately()
  * @method $this setLinksPurchasedSeparately(bool $value)
- * @method string getLinksTitle()
  * @method array getListSwatchAttrValues()
  *
  * @method array getMatchedRules()
@@ -261,9 +260,8 @@ class Mage_Catalog_Model_Product extends Mage_Catalog_Model_Abstract
      * Entity code.
      * Can be used as part of method name for entity processing
      */
-    public const ENTITY                 = 'catalog_product';
-
-    public const CACHE_TAG              = 'catalog_product';
+    public const ENTITY          = 'catalog_product';
+    public const CACHE_TAG       = 'catalog_product';
     protected $_cacheTag         = 'catalog_product';
     protected $_eventPrefix      = 'catalog_product';
     protected $_eventObject      = 'product';
@@ -675,6 +673,14 @@ public function getAttributes($groupId = null, $skipSuper = false)
         return $attributes;
     }
 
+    /**
+     * @return string
+     */
+    public function getLinksTitle()
+    {
+        return (string)$this->_getData('links_title');
+    }
+
     /**
      * @return Mage_CatalogInventory_Model_Stock_Item
      */

diff --git a/app/code/core/Mage/Downloadable/Helper/Catalog/Product/Configuration.php b/app/code/core/Mage/Downloadable/Helper/Catalog/Product/Configuration.php
@@ -59,7 +59,8 @@ public function getLinksTitle($product)
         if (strlen($title)) {
             return $title;
         }
-        return Mage::getStoreConfig(Mage_Downloadable_Model_Link::XML_PATH_LINKS_TITLE);
+
+        return (string)Mage::getStoreConfig(Mage_Downloadable_Model_Link::XML_PATH_LINKS_TITLE);
     }
 
     /**