From c7547af82d9e66359693285f5112aa9b5409b67d Mon Sep 17 00:00:00 2001 From: sv3n Date: Sun, 4 Dec 2022 07:36:14 +0100 Subject: [PATCH] Removed unreachable code (#2775) --- .../Block/Sales/Order/Create/Items/Grid.php | 1 - .../Sales/Order/Shipment/View/Tracking.php | 8 +- .../core/Mage/Adminhtml/Model/Config/Data.php | 3 - .../Model/System/Config/Backend/File.php | 1 - .../controllers/Api/RoleController.php | 1 - .../Permissions/RoleController.php | 3 +- .../Mage/Api2/Model/Acl/Global/Rule/Tree.php | 1 - app/code/core/Mage/Api2/Model/Resource.php | 4 +- .../Catalog/Helper/Product/Configuration.php | 2 - .../Mage/Catalog/Model/Product/Api/V2.php | 6 +- .../Model/Product/Option/Type/File.php | 3 +- .../Mage/CatalogIndex/Model/Aggregation.php | 1 - .../CatalogInventory/Model/Stock/Item.php | 3 +- .../CatalogSearch/Block/Advanced/Form.php | 4 - .../Mage/Core/Model/File/Storage/File.php | 2 - .../core/Mage/Core/Model/Resource/Setup.php | 1 - app/code/core/Mage/Core/functions.php | 10 -- .../Model/Customer/Attribute/Source/Store.php | 4 +- .../Dataflow/Model/Convert/Adapter/Io.php | 1 - .../Model/Convert/Parser/Xml/Excel.php | 69 ------------ .../core/Mage/Paygate/Model/Authorizenet.php | 1 - .../Mage/Sales/Model/Recurring/Profile.php | 1 - .../Mage/Shipping/Model/Carrier/Abstract.php | 4 +- .../Model/Resource/Catalog/Abstract.php | 1 - phpstan.dist.baseline.neon | 105 ------------------ 25 files changed, 16 insertions(+), 224 deletions(-) diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items/Grid.php b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items/Grid.php index 6898ecb2f57..7ce7c0a5d5e 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items/Grid.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items/Grid.php @@ -196,7 +196,6 @@ public function getSubtotalWithDiscount() if ($this->displayTotalsIncludeTax()) { return $address->getSubtotal() + $address->getTaxAmount() + $address->getHiddenTaxAmount() + $this->getDiscountAmount(); - return $subtotalInclTax; } return $address->getSubtotal() + $this->getDiscountAmount(); diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/View/Tracking.php b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/View/Tracking.php index 938c44166e8..07671b51887 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/View/Tracking.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/View/Tracking.php @@ -124,13 +124,15 @@ public function getCarriers() return $carriers; } + /** + * @param $code + * @return false|string + */ public function getCarrierTitle($code) { if ($carrier = Mage::getSingleton('shipping/config')->getCarrierInstance($code)) { return $carrier->getConfigData('title'); - } else { - return Mage::helper('sales')->__('Custom Value'); } - return false; + return Mage::helper('sales')->__('Custom Value'); } } diff --git a/app/code/core/Mage/Adminhtml/Model/Config/Data.php b/app/code/core/Mage/Adminhtml/Model/Config/Data.php index 731161f688f..ed68648a74a 100644 --- a/app/code/core/Mage/Adminhtml/Model/Config/Data.php +++ b/app/code/core/Mage/Adminhtml/Model/Config/Data.php @@ -468,13 +468,10 @@ protected function _isValidField($field) switch ($this->getScope()) { case self::SCOPE_DEFAULT: return (bool)(int)$field->show_in_default; - break; case self::SCOPE_WEBSITES: return (bool)(int)$field->show_in_website; - break; case self::SCOPE_STORES: return (bool)(int)$field->show_in_store; - break; } return true; diff --git a/app/code/core/Mage/Adminhtml/Model/System/Config/Backend/File.php b/app/code/core/Mage/Adminhtml/Model/System/Config/Backend/File.php index 35757772efa..1e8ad471696 100644 --- a/app/code/core/Mage/Adminhtml/Model/System/Config/Backend/File.php +++ b/app/code/core/Mage/Adminhtml/Model/System/Config/Backend/File.php @@ -59,7 +59,6 @@ protected function _beforeSave() $result = $uploader->save($uploadDir); } catch (Exception $e) { Mage::throwException($e->getMessage()); - return $this; } $filename = $result['file']; diff --git a/app/code/core/Mage/Adminhtml/controllers/Api/RoleController.php b/app/code/core/Mage/Adminhtml/controllers/Api/RoleController.php index d2c1688ae2f..4007e189ef0 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Api/RoleController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Api/RoleController.php @@ -221,7 +221,6 @@ protected function _deleteUserFromRole($userId, $roleId) ->deleteFromRole(); } catch (Exception $e) { throw $e; - return false; } return true; } diff --git a/app/code/core/Mage/Adminhtml/controllers/Permissions/RoleController.php b/app/code/core/Mage/Adminhtml/controllers/Permissions/RoleController.php index 533fcb972bb..b108b958d87 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Permissions/RoleController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Permissions/RoleController.php @@ -272,7 +272,7 @@ public function editrolegridAction() * * @param int $userId * @param int $roleId - * @return bool + * @return true */ protected function _deleteUserFromRole($userId, $roleId) { @@ -283,7 +283,6 @@ protected function _deleteUserFromRole($userId, $roleId) ->deleteFromRole(); } catch (Exception $e) { throw $e; - return false; } return true; } diff --git a/app/code/core/Mage/Api2/Model/Acl/Global/Rule/Tree.php b/app/code/core/Mage/Api2/Model/Acl/Global/Rule/Tree.php index 1e76852a1e4..705fbe17afd 100644 --- a/app/code/core/Mage/Api2/Model/Acl/Global/Rule/Tree.php +++ b/app/code/core/Mage/Api2/Model/Acl/Global/Rule/Tree.php @@ -136,7 +136,6 @@ public function __construct($options) default: throw new Exception(sprintf('Unknown tree type "%s".', $this->_type)); - break; } } diff --git a/app/code/core/Mage/Api2/Model/Resource.php b/app/code/core/Mage/Api2/Model/Resource.php index b885c8e990d..200dbbf1a22 100644 --- a/app/code/core/Mage/Api2/Model/Resource.php +++ b/app/code/core/Mage/Api2/Model/Resource.php @@ -201,7 +201,8 @@ public function dispatch() case self::ACTION_TYPE_ENTITY . self::OPERATION_CREATE: // Creation of objects is possible only when working with collection $this->_critical(self::RESOURCE_METHOD_NOT_IMPLEMENTED); - break; + // exception thrown + // no break case self::ACTION_TYPE_COLLECTION . self::OPERATION_CREATE: // If no of the methods(multi or single) is implemented, request body is not checked if (!$this->_checkMethodExist('_create') && !$this->_checkMethodExist('_multiCreate')) { @@ -282,7 +283,6 @@ public function dispatch() break; default: $this->_critical(self::RESOURCE_METHOD_NOT_IMPLEMENTED); - break; } } diff --git a/app/code/core/Mage/Catalog/Helper/Product/Configuration.php b/app/code/core/Mage/Catalog/Helper/Product/Configuration.php index 4f2010e0f94..1fec7bf816c 100644 --- a/app/code/core/Mage/Catalog/Helper/Product/Configuration.php +++ b/app/code/core/Mage/Catalog/Helper/Product/Configuration.php @@ -161,10 +161,8 @@ public function getOptions(Mage_Catalog_Model_Product_Configuration_Item_Interfa switch ($typeId) { case Mage_Catalog_Model_Product_Type_Configurable::TYPE_CODE: return $this->getConfigurableOptions($item); - break; case Mage_Catalog_Model_Product_Type_Grouped::TYPE_CODE: return $this->getGroupedOptions($item); - break; } return $this->getCustomOptions($item); } diff --git a/app/code/core/Mage/Catalog/Model/Product/Api/V2.php b/app/code/core/Mage/Catalog/Model/Product/Api/V2.php index ebf66b86ff8..f9ad0916e61 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Api/V2.php +++ b/app/code/core/Mage/Catalog/Model/Product/Api/V2.php @@ -204,7 +204,7 @@ public function update($productId, $productData, $store = null, $identifierType * @param array $productData * @param string|int $store * @param string $identifierType - * @return bool + * @return true|void */ public function multiUpdate($productIds, $productData, $store = null, $identifierType = null) { @@ -225,11 +225,9 @@ public function multiUpdate($productIds, $productData, $store = null, $identifie if (empty($failMessages)) { return true; - } else { - $this->_fault('partially_updated', implode("\n", $failMessages)); } - return false; + $this->_fault('partially_updated', implode("\n", $failMessages)); } /** diff --git a/app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php b/app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php index d34326a80fd..05dd2f627d4 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php +++ b/app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php @@ -193,7 +193,8 @@ protected function _validateUploadedFile() switch ($this->getProcessMode()) { case Mage_Catalog_Model_Product_Type_Abstract::PROCESS_MODE_FULL: Mage::throwException(Mage::helper('catalog')->__('Please specify the product required option %s.', $option->getTitle())); - break; + // exception thrown + // no break default: $this->setUserValue(null); break; diff --git a/app/code/core/Mage/CatalogIndex/Model/Aggregation.php b/app/code/core/Mage/CatalogIndex/Model/Aggregation.php index c4ea8e4bac5..d87ffc95bda 100644 --- a/app/code/core/Mage/CatalogIndex/Model/Aggregation.php +++ b/app/code/core/Mage/CatalogIndex/Model/Aggregation.php @@ -144,7 +144,6 @@ public function clearProductData($productIds) protected function _processKey($key) { return $key; - return md5($key); } /** diff --git a/app/code/core/Mage/CatalogInventory/Model/Stock/Item.php b/app/code/core/Mage/CatalogInventory/Model/Stock/Item.php index ded4ce1aaf7..2ac46114ba0 100644 --- a/app/code/core/Mage/CatalogInventory/Model/Stock/Item.php +++ b/app/code/core/Mage/CatalogInventory/Model/Stock/Item.php @@ -461,7 +461,7 @@ public function getCanBackInStock() * Check quantity * * @param float $qty - * @exception Mage_Core_Exception + * @throws Mage_Core_Exception * @return bool */ public function checkQty($qty) @@ -477,7 +477,6 @@ public function checkQty($qty) break; default: return false; - break; } } return true; diff --git a/app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php b/app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php index 1f37710ba38..23e78c933fa 100644 --- a/app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php +++ b/app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php @@ -145,10 +145,6 @@ public function getCurrencyCount() public function getCurrency($attribute) { return Mage::app()->getStore()->getCurrentCurrencyCode(); - - $baseCurrency = Mage::app()->getStore()->getBaseCurrency()->getCurrencyCode(); - return $this->getAttributeValue($attribute, 'currency') ? - $this->getAttributeValue($attribute, 'currency') : $baseCurrency; } /** diff --git a/app/code/core/Mage/Core/Model/File/Storage/File.php b/app/code/core/Mage/Core/Model/File/Storage/File.php index 61609189864..5cc28c77ecb 100644 --- a/app/code/core/Mage/Core/Model/File/Storage/File.php +++ b/app/code/core/Mage/Core/Model/File/Storage/File.php @@ -266,8 +266,6 @@ public function saveFile($file, $overwrite = true) } else { Mage::throwException(Mage::helper('core')->__('Wrong file info format')); } - - return false; } /** diff --git a/app/code/core/Mage/Core/Model/Resource/Setup.php b/app/code/core/Mage/Core/Model/Resource/Setup.php index fe6df25038f..07ac52b4e46 100644 --- a/app/code/core/Mage/Core/Model/Resource/Setup.php +++ b/app/code/core/Mage/Core/Model/Resource/Setup.php @@ -316,7 +316,6 @@ public function applyUpdates() break; default: return true; - break; } } elseif ($configVer) { $this->_installResourceDb($configVer); diff --git a/app/code/core/Mage/Core/functions.php b/app/code/core/Mage/Core/functions.php index 5b87122df18..0dce97d3794 100644 --- a/app/code/core/Mage/Core/functions.php +++ b/app/code/core/Mage/Core/functions.php @@ -231,21 +231,11 @@ function mageDebugBacktrace($return = false, $html = true, $showFirst = false) function mageSendErrorHeader() { return; - if (!isset($_SERVER['SCRIPT_NAME'])) { - return; - } - $action = Mage::app()->getRequest()->getBasePath() . "bugreport.php"; - echo ''; - exit; } /** diff --git a/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Store.php b/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Store.php index a7785329e52..6eeaf489e5b 100644 --- a/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Store.php +++ b/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Store.php @@ -81,9 +81,7 @@ public function getOptionText($value) $values[] = $this->_options[$val]; } return $values; - } else { - return $this->_options[$value]; } - return false; + return $this->_options[$value]; } } diff --git a/app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php b/app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php index 2351a968215..2adf78521f5 100644 --- a/app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php +++ b/app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php @@ -54,7 +54,6 @@ public function getResource($forWrite = false) if (!$validator->isValid($path)) { foreach ($validator->getMessages() as $message) { Mage::throwException($message); - return false; } } diff --git a/app/code/core/Mage/Dataflow/Model/Convert/Parser/Xml/Excel.php b/app/code/core/Mage/Dataflow/Model/Convert/Parser/Xml/Excel.php index 2591601997a..edb2712296c 100644 --- a/app/code/core/Mage/Dataflow/Model/Convert/Parser/Xml/Excel.php +++ b/app/code/core/Mage/Dataflow/Model/Convert/Parser/Xml/Excel.php @@ -154,75 +154,6 @@ public function parse() ->save(); return $this; - - $dom = new DOMDocument(); - if (Mage::app()->getRequest()->getParam('files')) { - $path = Mage::app()->getConfig()->getTempVarDir() . '/import/'; - $file = $path . urldecode(Mage::app()->getRequest()->getParam('files')); - if (file_exists($file)) { - $dom->load($file); - } - } else { - $this->validateDataString(); - $dom->loadXML($this->getData()); - } - - $worksheets = $dom->getElementsByTagName('Worksheet'); - if ($this->getVar('adapter') && $this->getVar('method')) { - $adapter = Mage::getModel($this->getVar('adapter')); - } - foreach ($worksheets as $worksheet) { - $wsName = $worksheet->getAttribute('ss:Name'); - $rows = $worksheet->getElementsByTagName('Row'); - $firstRow = true; - $fieldNames = []; - $wsData = []; - $i = 0; - foreach ($rows as $rowSet) { - $index = 1; - $cells = $rowSet->getElementsByTagName('Cell'); - $rowData = []; - foreach ($cells as $cell) { - $value = $cell->getElementsByTagName('Data')->item(0)->nodeValue; - $ind = $cell->getAttribute('ss:Index'); - if (!is_null($ind) && $ind > 0) { - $index = $ind; - } - if ($firstRow && !$this->getVar('fieldnames')) { - $fieldNames[$index] = 'column' . $index; - } - if ($firstRow && $this->getVar('fieldnames')) { - $fieldNames[$index] = $value; - } else { - $rowData[$fieldNames[$index]] = $value; - } - $index++; - } - $row = $rowData; - if ($row) { - $loadMethod = $this->getVar('method'); - $adapter->$loadMethod(compact('i', 'row')); - } - $i++; - - $firstRow = false; - if (!empty($rowData)) { - $wsData[] = $rowData; - } - } - $data[$wsName] = $wsData; - $this->addException('Found worksheet "' . $wsName . '" with ' . count($wsData) . ' row(s)'); - } - if ($wsName = $this->getVar('single_sheet')) { - if (isset($data[$wsName])) { - $data = $data[$wsName]; - } else { - reset($data); - $data = current($data); - } - } - $this->setData($data); - return $this; } /** diff --git a/app/code/core/Mage/Paygate/Model/Authorizenet.php b/app/code/core/Mage/Paygate/Model/Authorizenet.php index 9db69b8ba92..4b1fd6f6327 100644 --- a/app/code/core/Mage/Paygate/Model/Authorizenet.php +++ b/app/code/core/Mage/Paygate/Model/Authorizenet.php @@ -593,7 +593,6 @@ protected function _place($payment, $amount, $requestType) default: Mage::throwException($defaultExceptionMessage); } - return $this; } /** diff --git a/app/code/core/Mage/Sales/Model/Recurring/Profile.php b/app/code/core/Mage/Sales/Model/Recurring/Profile.php index 94afdd18de9..6d8e06089b3 100644 --- a/app/code/core/Mage/Sales/Model/Recurring/Profile.php +++ b/app/code/core/Mage/Sales/Model/Recurring/Profile.php @@ -459,7 +459,6 @@ public function getFieldComment($field) default: return parent::getFieldComment($field); } - return null; } /** diff --git a/app/code/core/Mage/Shipping/Model/Carrier/Abstract.php b/app/code/core/Mage/Shipping/Model/Carrier/Abstract.php index be1d1b08cf3..f2bd76f1862 100644 --- a/app/code/core/Mage/Shipping/Model/Carrier/Abstract.php +++ b/app/code/core/Mage/Shipping/Model/Carrier/Abstract.php @@ -112,7 +112,7 @@ abstract class Mage_Shipping_Model_Carrier_Abstract extends Varien_Object * Retrieve information from carrier configuration * * @param string $field - * @return mixed + * @return string|false */ public function getConfigData($field) { @@ -514,7 +514,7 @@ public function getTotalNumOfBoxes($weight) */ $this->_numBoxes = 1; $weight = $this->convertWeightToLbs($weight); - $maxPackageWeight = $this->getConfigData('max_package_weight'); + $maxPackageWeight = (float)$this->getConfigData('max_package_weight'); if ($weight > $maxPackageWeight && $maxPackageWeight != 0) { $this->_numBoxes = ceil($weight / $maxPackageWeight); $weight = $weight / $this->_numBoxes; diff --git a/app/code/core/Mage/Sitemap/Model/Resource/Catalog/Abstract.php b/app/code/core/Mage/Sitemap/Model/Resource/Catalog/Abstract.php index 5651bdb88cd..8f1a5444aa6 100644 --- a/app/code/core/Mage/Sitemap/Model/Resource/Catalog/Abstract.php +++ b/app/code/core/Mage/Sitemap/Model/Resource/Catalog/Abstract.php @@ -98,7 +98,6 @@ protected function _addFilter($storeId, $attributeCode, $value, $type = '=') break; default: return false; - break; } if ($attribute['backend_type'] == 'static') { diff --git a/phpstan.dist.baseline.neon b/phpstan.dist.baseline.neon index 514162b1a5d..ecf48a0b04e 100644 --- a/phpstan.dist.baseline.neon +++ b/phpstan.dist.baseline.neon @@ -1085,11 +1085,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items/Grid.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items/Grid.php - - message: "#^Call to method getIsOldCustomer\\(\\) on an unknown class Mage_Adminhtml_Model_Quote\\.$#" count: 1 @@ -1230,11 +1225,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/View/Items.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/View/Tracking.php - - message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 @@ -1865,11 +1855,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Model/Config/Data.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 3 - path: app/code/core/Mage/Adminhtml/Model/Config/Data.php - - message: "#^Method Mage_Eav_Model_Entity_Abstract\\:\\:load\\(\\) invoked with 1 parameter, 2\\-3 required\\.$#" count: 1 @@ -2025,11 +2010,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Model/System/Config/Backend/File.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Model/System/Config/Backend/File.php - - message: "#^Comparison operation \"\\=\\=\" between \\(Varien_Simplexml_Element\\|null\\) and 1 results in an error\\.$#" count: 1 @@ -2055,11 +2035,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Model/System/Store.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Api/RoleController.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" count: 1 @@ -2185,11 +2160,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/controllers/Permissions/BlockController.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Permissions/RoleController.php - - message: "#^Comparison operation \"\\>\\=\" between int\\<1, max\\> and 1 is always true\\.$#" count: 1 @@ -2695,11 +2665,6 @@ parameters: count: 1 path: app/code/core/Mage/Api2/Model/Acl/Global/Rule/ResourcePermission.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Model/Acl/Global/Rule/Tree.php - - message: "#^Variable \\$operationName might not be defined\\.$#" count: 2 @@ -3860,11 +3825,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Helper/Product/Configuration.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Helper/Product/Configuration.php - - message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:loadSelf\\(\\)\\.$#" count: 1 @@ -4615,11 +4575,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php - - message: "#^Variable \\$value in isset\\(\\) always exists and is not nullable\\.$#" count: 1 @@ -5575,11 +5530,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/controllers/Seo/SitemapController.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/CatalogIndex/Model/Aggregation.php - - message: "#^Call to an undefined method Mage_CatalogIndex_Model_Resource_Attribute\\:\\:checkCount\\(\\)\\.$#" count: 1 @@ -5900,11 +5850,6 @@ parameters: count: 1 path: app/code/core/Mage/CatalogInventory/Model/Stock/Item.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/CatalogInventory/Model/Stock/Item.php - - message: "#^Variable \\$parentItem in empty\\(\\) always exists and is not falsy\\.$#" count: 1 @@ -6025,11 +5970,6 @@ parameters: count: 1 path: app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php - - message: "#^Parameter \\#2 \\$offset of function array_slice expects int, float given\\.$#" count: 1 @@ -7465,11 +7405,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/File/Storage/File.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/File/Storage/File.php - - message: "#^Call to function is_string\\(\\) with array will always evaluate to false\\.$#" count: 1 @@ -7860,11 +7795,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Resource/Setup.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Setup.php - - message: "#^Binary operation \"\\.\" between string and array results in an error\\.$#" count: 1 @@ -8205,11 +8135,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/functions.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 2 - path: app/code/core/Mage/Core/functions.php - - message: "#^Strict comparison using \\=\\=\\= between int\\|string and null will always evaluate to false\\.$#" count: 1 @@ -8500,11 +8425,6 @@ parameters: count: 1 path: app/code/core/Mage/Customer/Model/Customer/Api/V2.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Store.php - - message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 @@ -8715,11 +8635,6 @@ parameters: count: 3 path: app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php - - message: "#^Negated boolean expression is always false\\.$#" count: 1 @@ -8820,11 +8735,6 @@ parameters: count: 2 path: app/code/core/Mage/Dataflow/Model/Convert/Parser/Xml/Excel.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Parser/Xml/Excel.php - - message: "#^Method Mage_Dataflow_Model_Convert_Profile_Abstract\\:\\:run\\(\\) should return Mage_Dataflow_Model_Convert_Profile_Abstract but empty return statement found\\.$#" count: 2 @@ -10815,11 +10725,6 @@ parameters: count: 1 path: app/code/core/Mage/Paygate/Model/Authorizenet.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Variable \\$defaultExceptionMessage might not be defined\\.$#" count: 2 @@ -13955,11 +13860,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Recurring/Profile.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Recurring/Profile.php - - message: "#^Parameter \\#2 \\$attribute of method Mage_Sales_Model_Resource_Order_Abstract\\:\\:_afterSaveAttribute\\(\\) expects string, array given\\.$#" count: 1 @@ -14555,11 +14455,6 @@ parameters: count: 1 path: app/code/core/Mage/Sitemap/Model/Resource/Catalog/Abstract.php - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Sitemap/Model/Resource/Catalog/Abstract.php - - message: "#^Negated boolean expression is always false\\.$#" count: 1