Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OM is not reloading the cart page if deleting a product from cart side block #2204

Closed
ADDISON74 opened this issue Jun 7, 2022 · 2 comments
Closed

Comments

@ADDISON74
Copy link
Contributor

Steps to reproduce

  1. Add a product to cart
  2. If you are not redirected go to cart page
  3. Delete the product from cart side block by clicking "Remove Item" link

Expected result

  1. Cart page should be reloaded automatically showing no product

Actual result

  1. Cart page still shows the product in cart, even the cart side block is empty
  2. If you reload the page there is no product listed, as it should be

This is before removing the product

before

This is after removing the product

after

Comments

  1. The Magento 2 team fixed this issue last year. Here is the merged PR Fixed Magento is no refreshing the cart page if you delete a product from cart side block magento/magento2#22478.

  2. When I did the reporting in Magento 2 group I had an exchange of ideas with a gentleman without manners. He claimed that it was a bad UX practice to use that side block, that no one was using it anymore, but he did not offer any solution. Fortunately, the Magento team had take in consideration the issue.

Personal Opinions

  1. I do not agree with the removal of the side block dedicated to the cart because it is helpful for tablets and desktops.

  2. If you do not want a page reload implementation then the link "Remove Item" should be deleted to avoid the issue. Thus the removal of the products from the cart will be done from grid not from the side block.

  3. I would go for the version proposed by the Magento team keeping the the link "Remove Item" but if it is too complicated to implement the code I suggest its removing.

@ADDISON74 ADDISON74 changed the title OM is no refreshing the cart page if deleting a product from cart side block OM is no reloading the cart page if deleting a product from cart side block Jun 7, 2022
@ADDISON74 ADDISON74 changed the title OM is no reloading the cart page if deleting a product from cart side block OM is not reloading the cart page if deleting a product from cart side block Jun 7, 2022
@Flyingmana
Copy link
Contributor

2 more options:

  1. remove the link only, if on a cart page
  2. do the reload only on the cart page

I prefer 5. and it shouldnt be hard. Either we check for the url, or for the existence of cart specific class= elements to decide regarding the reload.

@fballiano
Copy link
Contributor

The patch used in M2 does point number 5:

Screenshot 2023-01-21 alle 20 17 49

it shouldn't be that hard to do, let's see if I can get it to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants