-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some mass actions in Orders grid don't have a confirmation dialog #2323
Comments
I don't know how feasible it is to also show in the confirmation dialog how many orders the action will apply to, that would help too. |
We removed the cancel item years ago /** @var Mage_Adminhtml_Block_Sales_Order_Grid $this */
$this->getMassactionBlock()->removeItem('cancel_order');
$this->getMassactionBlock()->removeItem('hold_order''); |
Some mass actions can be really dangerous so it would be nice to have a confirmation prompt, also a "are you sure?" is better than nothing. So I really don't know what I would do here. |
Funny, today morning, I also thought: It would be really helpful to at least get reminded about the number of selected items this mass action affects. (e.g. when mixing up "select visible" and "select all") /Edit: Or how about a warning, when "select all" is clicked? |
@daboss84 Yeah, there's many different ways to tackle this, a warning will be a good first step. I will add this to my hacktober contributions list if no one picks it. |
Two days ago one of our team members accidentally canceled all pending orders thinking he applied an email filter. Luckily there were only a few orders at that time and we were able to un-cancel them quickly.
I think that in general all grids should have a confirmation dialog for potentially dangerous/destructive actions to protect from accidents like these. Any other suggestions to solve this are welcomed.
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Actual result (*)
The text was updated successfully, but these errors were encountered: