-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge functionality of Aoe_Layout module. #292
Comments
looks ok for me, but a bit more documentation would be nice |
The repo https://github.com/AOEpeople/Aoe_Layout has no readme file. What does Aoe_Layout add to Magento core? |
It does have a readme, but it doesn't explain what the module does exactly. It's meant to enhance several areas of the Layout XML in Magento.
|
Also, there are several bits that shouldn't be merged to this repo that are related to generic model handling. |
I'll generate several PRs for this as changes to the core classes instead of as an extension. Each mini-feature will be it's own PR. |
Hi. I'm a merchant.And I never used such things like above (layout module).. and I doubt I will. |
@tomekjordan thank you for pointing out your worries. If you feel your Issue is to urgent to wait, and is directly impacting your revenue, Iam sure we can find a Developer who has some paid time left in the schedule. |
@tomekjordan Particually disagree in this ;) From merchants view ... For me Magento definitly lacks of some layout options that are "required" to customize a shop to your/my needs, like https://github.com/netz98/N98_LayoutHelper (a must - adding css/js in the wight order, remove account link) or some part of Codnitive_Extifcon (for more flexible layouts - cond. if helpers...) (1) So, adding things like this makes Magento more USABLE (for me)
Definitly agreeded in priority, BUT we all do this here for free and maybe focus on problems we are confrontated with (and have solutions i mind), If you want your issues fixed, please make a PR. If you dont know how to fix, then please add a clearly reproducable step-by-step guide.
... :P
Some things should be core features .... (1) @LeeSaferite can you please add a description to Aoe_Layout? |
Found a blog post where it was already mentioned that it should belong to core ... posted 6y ago :)
Let's start :) If you need some help ... |
I'll work on it this weekend |
Some news :) ? |
Talk about dropping a ball. I haven't had any time at all to manage this. If someone wants to start I can provided feedback on what should be done. |
I would suggest to just add the Aoe_Layout module to our "suggested modules" and that's it, it's been 5 years already so... |
I'm closing this since it seems it's dead. Anybody is welcome to reopen it or better provide a PR. |
As per #282 and #283 this issue is to discuss the inclusion of the functionality added by the Aoe_Layout module. Whereas @LeeSaferite has offered to include it into LTS core and there is no BC issue and it improves the Magento core substantially and is not a "feature" per-se but makes it easier to properly enable/disable features it has my vote for inclusion.
The text was updated successfully, but these errors were encountered: