Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions - check-files job fails in case of large number of changed files #3275

Closed
gorbunovav opened this issue May 19, 2023 · 3 comments · Fixed by #3276
Closed

GitHub Actions - check-files job fails in case of large number of changed files #3275

gorbunovav opened this issue May 19, 2023 · 3 comments · Fixed by #3276

Comments

@gorbunovav
Copy link
Contributor

Summary (*)

E.g. in #3120 8K files were updated.
In the current form check-files tries to calculate number of changed files of different types. To achieve this the full list of changed files is emitted into each bash expression.
Expressions are all listed in one step of the job, which leads to too large template size.

Examples (*)

#3120

Proposed solution

We can split job into several steps - this way template for each step will be not that large.

@ADDISON74
Copy link
Contributor

This problem does not concern the source code of OpenMage, but is a proposal for a certain situation in the case of PRs where many files are modified. the most appropriate place to discuss the proposal would be Discussions > Ideas.

gorbunovav added a commit to BudsiesApp/magento-lts that referenced this issue May 19, 2023
…nto steps as a workaround for step template size limit
@gorbunovav
Copy link
Contributor Author

@ADDISON74 Workflow specs for GitHub actions are part of this repo.
I've created a PR with the fix proposed - it doesn't contain any specific logic branches for large PRs: the same approach is used for all cases.

Do you want me to additionally create a discussion?

gorbunovav added a commit to BudsiesApp/magento-lts that referenced this issue May 19, 2023
…nto steps as a workaround for step template size limit
@ADDISON74
Copy link
Contributor

Since you created a PR there will be discussions. I don't consider it necessary to create another topic on this topic. I appreciate your work.

fballiano added a commit that referenced this issue May 21, 2023
…round for step template size limit (#3276)

* Refs #3275: GitHub Actions - `check-files` workflow - split into steps as a workaround for step template size limit

* Update .all-contributorsrc

---------

Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants