Discussion: Consider using PHP CS Fixer and/or PHPStan

[colinmollenhour]

• Initially run CS Fixer to update all code to conform to a standard
• Add Travis pipeline or Github Action to throw error when CS Fixer output is different from pushed code (showing diff)

#693 (comment)
#365

[colinmollenhour]

@sreichel What are the pros/cons of PHP CS Fixer and PHPStan and are they completely redundant?

[tmotyl]

Php fixer just take care of CGL and can fix the formatting. While phpstan does static code analysis but cant fix code.

So we need both :)

[sreichel]

@sreichel What are the pros/cons of PHP CS Fixer and PHPStan and are they completely redundant?

As @tmotyl said. No, they aren't redundant.

IMHO cs-fixer is "just" a nice to have to have code matching PSR2 standard or whatever. phpstan/psalm is to prevent logical problems .... can't find it actually, but there was a nice article about predicted or expected variables ....

[kkrieger85]

+1 for phpcsfixer for PSR2
php php-cs-fixer.phar fix /path/to/project --rules=@PSR2

This could also improve to review PR like #1035 and all other PR consider code style