Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Mage_GoogleBase #1002

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Removed Mage_GoogleBase #1002

merged 1 commit into from
Jun 5, 2020

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented May 23, 2020

Ref #416

GoogleBase is deprecated since 1.5.1 .... can we remove it?

@Flyingmana
Copy link
Contributor

The Question is, does it still work?
And if yes, then this has to go through an RFC

@sreichel
Copy link
Contributor Author

sreichel commented May 23, 2020

1.6.0.0-alpha1 changelog .... a562c7f#diff-ccb38245ef0f8b85d3770014ac70334b

Deprecated GoogleBase module (http://googlemerchantblog.blogspot.com/2010/12/new-shopping-apis-and-deprecation-of.html)

It does not work anymore. All code is commented ...

@sreichel sreichel mentioned this pull request May 23, 2020
@colinmollenhour colinmollenhour merged commit 53f8319 into OpenMage:1.9.4.x Jun 5, 2020
@sreichel sreichel deleted the cleanup/dead/googlebase branch June 5, 2020 21:51
@sreichel sreichel restored the cleanup/dead/googlebase branch June 20, 2020 02:57
@sreichel sreichel added this to the Release 19.4.4 milestone Jun 26, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants