Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Magento Admin to OpenMage Admin #1046

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

luigifab
Copy link
Contributor

:) the downloader update is probably useless.

Copy link
Contributor

@sreichel sreichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about locale packs? (no idea atm)

@colinmollenhour
Copy link
Member

Related: #1014 and #903

@sreichel
Copy link
Contributor

Mhhh ... keep php-code and just change translation (to do not break locale packs?)

@luigifab
Copy link
Contributor Author

luigifab commented Jun 18, 2020

Mhhh ... keep php-code and just change translation (to do not break locale packs?)

:'( perhaps we can create a PR that add all "updated" translations packs to OpenMage? I will very happy to try.

@sreichel
Copy link
Contributor

Off-Topic and just a reminder for me .... https://crowdin.com/project/magento-1 ...

I've no problem to ask for free support for an OS project .... would this be an improvement to handle translations?

@sreichel sreichel added the rebranding Change Magento to OpenMage LTS label Jun 23, 2020
kkrieger85
kkrieger85 previously approved these changes Jun 24, 2020
Copy link
Contributor

@kkrieger85 kkrieger85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sreichel sreichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For new translations (locale pack breaking changes) i'd prefer custom CSV as suggest in README.

@colinmollenhour colinmollenhour merged commit 982395a into OpenMage:1.9.4.x Jun 26, 2020
@luigifab luigifab deleted the openmage-admin branch June 30, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rebranding Change Magento to OpenMage LTS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants