Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features from N98 layout helper #1051

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Add features from N98 layout helper #1051

merged 2 commits into from
Mar 12, 2021

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jun 20, 2020

See #321, #336 (netz98/N98_LayoutHelper#10)
Ref #416

N98_LayoutHelper is one of the modules that i have used everywhere ... most important function are already in LTS core code (remove links, improved breadcrumbs), only one usefull change at Page_Head is left ...

This PR adds two args to Mage_Page_Block_Html_Head::addItem() mehtod ...

     * @param string $referenceName name of the item to insert the element before. If name is not found, insert at the end, * has special meaning (before all / before all)
     * @param bool $before If true insert before the $referenceName instead of after

(todo ... change composer.json to prevent install of N98 module, add documentation)

@sreichel sreichel added new feature Component: Page Relates to Mage_Page labels Jun 20, 2020
@sreichel sreichel mentioned this pull request Jun 20, 2020
@sreichel sreichel marked this pull request as draft June 20, 2020 23:57
@sreichel sreichel marked this pull request as ready for review June 21, 2020 04:44
@sreichel sreichel marked this pull request as draft June 21, 2020 04:45
@rjocoleman
Copy link
Contributor

@sreichel do you want a hand with this?

I can add:

{
  "replace": {
    "n98/n98_layouthelper": "*"
  }
}
  • Some docs, as this feature is super useful but quite hard to understand, so docs are important - where should they go?

@sreichel sreichel marked this pull request as ready for review March 2, 2021 19:17
@sreichel sreichel merged commit 57563fc into OpenMage:1.9.4.x Mar 12, 2021
@sreichel sreichel deleted the feature/n98-head branch March 12, 2021 21:44
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 57563fc. ± Comparison against base commit 89a7f2b.

sreichel added a commit that referenced this pull request Mar 12, 2021
@sreichel sreichel added this to the Release 19.4.12 / 20.0.8 milestone Mar 12, 2021
@sreichel sreichel mentioned this pull request Aug 5, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Page Relates to Mage_Page new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants