Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression from PR #103. Forgot to use array access by reference... #111

Merged
merged 2 commits into from
Oct 11, 2016
Merged

Fix regression from PR #103. Forgot to use array access by reference... #111

merged 2 commits into from
Oct 11, 2016

Conversation

colinmollenhour
Copy link
Member

Whoops.. This is a pretty important fix as the stock indexers are not run after order completion without it.

alexkirsch
alexkirsch approved these changes Oct 10, 2016
View reviewed changes
Copy link
Contributor

@alexkirsch alexkirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@colinmollenhour colinmollenhour merged commit 7f1a054 into OpenMage:1.9.2.4 Oct 11, 2016
@colinmollenhour colinmollenhour deleted the fix-pr103-regression branch October 11, 2016 16:48
@tmotyl tmotyl mentioned this pull request Mar 16, 2017
Closed
@sreichel sreichel added the bug label Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsch alexkirsch alexkirsch approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colinmollenhour @alexkirsch @sreichel