Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression from PR #103. Forgot to use array access by reference... #111

Merged
merged 2 commits into from
Oct 11, 2016
Merged

Fix regression from PR #103. Forgot to use array access by reference... #111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7804594
Fix regression from PR #103. Forgot to use array access by reference...
colinmollenhour Oct 10, 2016
6244f7b
Use older array syntax
alexkirsch Oct 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/core/Mage/CatalogInventory/Model/Resource/Stock.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,10 @@ public function getProductsStock($stock, $productIds, $lockRows = false)
// so using a separate query here significantly reduces the number of
// unnecessarily locked rows in other tables, thereby avoiding deadlocks.
$select = $this->_getWriteAdapter()->select()
->from($productTable, ['entity_id', 'type_id'])
->from($productTable, array('entity_id', 'type_id'))
->where('entity_id IN(?)', $productIds);
$typeIds = $this->_getWriteAdapter()->fetchPairs($select);
foreach ($rows as $row) {
foreach ($rows as &$row) {
$row['type_id'] = $typeIds[$row['product_id']];
}
return $rows;
Expand Down