Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Zend Lib Deprecated Notice PHP8 #1349

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Fixed Zend Lib Deprecated Notice PHP8 #1349

merged 1 commit into from
Dec 28, 2020

Conversation

daim2k5
Copy link
Contributor

@daim2k5 daim2k5 commented Dec 13, 2020

Description (*)

bugfix(zend) Deprecated: Required parameter $A follows optional parameter $B (example)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes github action "Static Code Analyses" experimental workflows contain failures #1271

Manual testing scenarios (*)

Questions or comments

Only one function was call from another one.

public function deleteMessage
/lib/Zend/Service/WindowsAzure/Storage/Queue.php:522

Deprecated: Required parameter $packageUrl follows optional parameter $staging in ./Service/WindowsAzure/CommandLine/Deployment.php on line 82
Deprecated: Required parameter $serviceConfigurationLocation follows optional parameter $staging in ./Service/WindowsAzure/CommandLine/Deployment.php on line 82
Deprecated: Required parameter $packageLocation follows optional parameter $staging in ./Service/WindowsAzure/CommandLine/Deployment.php on line 126
Deprecated: Required parameter $serviceConfigurationLocation follows optional parameter $staging in ./Service/WindowsAzure/CommandLine/Deployment.php on line 126
Deprecated: Required parameter $storageAccount follows optional parameter $staging in ./Service/WindowsAzure/CommandLine/Deployment.php on line 126
Deprecated: Required parameter $property follows optional parameter $algorithm in ./Service/WindowsAzure/CommandLine/Certificate.php on line 146
Deprecated: Required parameter $message follows optional parameter $queueName in ./Service/WindowsAzure/Storage/Queue.php on line 522
Deprecated: Required parameter $configuration follows optional parameter $roleInstance in ./Service/WindowsAzure/Diagnostics/Manager.php on line 212
Deprecated: Required parameter $context follows optional parameter $genNum in ./Pdf/Element/Reference.php on line 91
Deprecated: Required parameter $factory follows optional parameter $genNum in ./Pdf/Element/Reference.php on line 91
Deprecated: Required parameter $recipientUserName follows optional parameter $videoEntry in ./Gdata/YouTube.php on line 802

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@daim2k5 daim2k5 changed the title Fixed Zend Lib Tool Deprecated Notice PHP8 Fixed Zend Lib Deprecated Notice PHP8 Dec 13, 2020
@Flyingmana Flyingmana added the PHP 8 Related to PHP8 label Dec 28, 2020
@Flyingmana Flyingmana merged commit 79e36ff into OpenMage:1.9.4.x Dec 28, 2020
@github-actions
Copy link
Contributor

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
2 runs  2 ✔️ 0 💤 0 ❌

Results for commit 79e36ff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: lib/* Relates to lib/* PHP 8 Related to PHP8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github action "Static Code Analyses" experimental workflows contain failures
3 participants