Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Zend Lib Deprecated Notice PHP8 #1349

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Fixed Zend Lib Deprecated Notice PHP8 #1349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Zend/Gdata/YouTube.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,8 +799,8 @@ public function getInboxFeedForCurrentUser()
* Zend_Gdata_YouTube_Inbox_Entry representing the sent message.
*
*/
public function sendVideoMessage($body, $videoEntry = null,
$videoId = null, $recipientUserName)
public function sendVideoMessage($body, $videoEntry,
$videoId, $recipientUserName)
{
if (!$videoId && !$videoEntry) {
#require_once 'Zend/Gdata/App/InvalidArgumentException.php';
Expand Down
2 changes: 1 addition & 1 deletion lib/Zend/Pdf/Element/Reference.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class Zend_Pdf_Element_Reference extends Zend_Pdf_Element
* @param Zend_Pdf_ElementFactory $factory
* @throws Zend_Pdf_Exception
*/
public function __construct($objNum, $genNum = 0, Zend_Pdf_Element_Reference_Context $context, Zend_Pdf_ElementFactory $factory)
public function __construct($objNum, $genNum, Zend_Pdf_Element_Reference_Context $context, Zend_Pdf_ElementFactory $factory)
{
if ( !(is_integer($objNum) && $objNum > 0) ) {
#require_once 'Zend/Pdf/Exception.php';
Expand Down
2 changes: 1 addition & 1 deletion lib/Zend/Service/WindowsAzure/CommandLine/Certificate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ public function getCertificateCommand($subscriptionId, $certificate, $certificat
* @command-example Get certificate for service name "phptest":
* @command-example Get -sid:"<your_subscription_id>" -cert:"mycert.pem" -sn:"phptest" --CertificateThumbprint:"<thumbprint>" --CertificateAlgorithm:"sha1"
*/
public function getCertificatePropertyCommand($subscriptionId, $certificate, $certificatePassphrase, $serviceName, $thumbprint, $algorithm = "sha1", $property)
public function getCertificatePropertyCommand($subscriptionId, $certificate, $certificatePassphrase, $serviceName, $thumbprint, $algorithm, $property)
{
$client = new Zend_Service_WindowsAzure_Management_Client($subscriptionId, $certificate, $certificatePassphrase);
$result = $client->getCertificate($serviceName, $algorithm, $thumbprint);
Expand Down
9 changes: 5 additions & 4 deletions lib/Zend/Service/WindowsAzure/CommandLine/Deployment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class Zend_Service_WindowsAzure_CommandLine_Deployment
* @command-example --PackageUrl:"http://acct.blob.core.windows.net/pkgs/service.cspkg"
* @command-example --ServiceConfigLocation:".\ServiceConfiguration.cscfg" --StartImmediately --WaitFor
*/
public function createFromStorageCommand($subscriptionId, $certificate, $certificatePassphrase, $serviceName, $deploymentName, $label, $staging = false, $production = false, $packageUrl, $serviceConfigurationLocation, $startImmediately = true, $warningsAsErrors = false, $waitForOperation = false)
public function createFromStorageCommand($subscriptionId, $certificate, $certificatePassphrase, $serviceName, $deploymentName, $label, $staging , $production , $packageUrl, $serviceConfigurationLocation, $startImmediately = true, $warningsAsErrors = false, $waitForOperation = false)
{
$deploymentSlot = 'staging';
if (!$staging && !$production) {
Expand All @@ -90,12 +90,13 @@ public function createFromStorageCommand($subscriptionId, $certificate, $certifi
$deploymentSlot = 'production';
}

$client->createDeployment($serviceName, $deploymentSlot, $deploymentName, $label, $packageUrl, $serviceConfigurationLocation, $startImmediately, $warningsAsErrors);
// $client was never set probably dead code
/*$client->createDeployment($serviceName, $deploymentSlot, $deploymentName, $label, $packageUrl, $serviceConfigurationLocation, $startImmediately, $warningsAsErrors);

if ($waitForOperation) {
$client->waitForOperation();
}
echo $client->getLastRequestId();
echo $client->getLastRequestId();*/
}

/**
Expand Down Expand Up @@ -123,7 +124,7 @@ public function createFromStorageCommand($subscriptionId, $certificate, $certifi
* @command-example --ServiceConfigLocation:".\ServiceConfiguration.cscfg" --StorageAccount:"mystorage"
* @command-example --StartImmediately --WaitFor
*/
public function createFromLocalCommand($subscriptionId, $certificate, $certificatePassphrase, $serviceName, $deploymentName, $label, $staging = false, $production = false, $packageLocation, $serviceConfigurationLocation, $storageAccount, $startImmediately = true, $warningsAsErrors = false, $waitForOperation = false)
public function createFromLocalCommand($subscriptionId, $certificate, $certificatePassphrase, $serviceName, $deploymentName, $label, $staging , $production, $packageLocation, $serviceConfigurationLocation, $storageAccount, $startImmediately = true, $warningsAsErrors = false, $waitForOperation = false)
{
$deploymentSlot = 'staging';
if (!$staging && !$production) {
Expand Down
2 changes: 1 addition & 1 deletion lib/Zend/Service/WindowsAzure/Diagnostics/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ public function getConfigurationForRoleInstance($roleInstance = null)
* @param Zend_Service_WindowsAzure_Diagnostics_ConfigurationInstance $configuration Configuration to apply
* @throws Zend_Service_WindowsAzure_Diagnostics_Exception
*/
public function setConfigurationForRoleInstance($roleInstance = null, Zend_Service_WindowsAzure_Diagnostics_ConfigurationInstance $configuration)
public function setConfigurationForRoleInstance($roleInstance, Zend_Service_WindowsAzure_Diagnostics_ConfigurationInstance $configuration)
{
if (is_null($roleInstance)) {
#require_once 'Zend/Service/WindowsAzure/Diagnostics/Exception.php';
Expand Down
2 changes: 1 addition & 1 deletion lib/Zend/Service/WindowsAzure/Storage/Queue.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ public function clearMessages($queueName = '')
* @param Zend_Service_WindowsAzure_Storage_QueueMessage $message Message to delete from queue. A message retrieved using "peekMessages" can NOT be deleted!
* @throws Zend_Service_WindowsAzure_Exception
*/
public function deleteMessage($queueName = '', Zend_Service_WindowsAzure_Storage_QueueMessage $message)
public function deleteMessage($queueName, Zend_Service_WindowsAzure_Storage_QueueMessage $message)
{
if ($queueName === '') {
#require_once 'Zend/Service/WindowsAzure/Exception.php';
Expand Down