Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo: Replace 'Retrive' with 'Retrieve' globally #1995

Merged
merged 3 commits into from
Jan 31, 2022
Merged

Fix typo: Replace 'Retrive' with 'Retrieve' globally #1995

merged 3 commits into from
Jan 31, 2022

Conversation

tmewes
Copy link
Contributor

@tmewes tmewes commented Jan 28, 2022 •
edited
Loading

Description (*)

This pull request replaces the typo Retrive with Retrieve (and also retrive with retrieve) globally.

With one exception, the typo only appeared in comments and API documentation.
This one exception is a single XML node in the api.xml of Mage_Checkout. This is only relevant for an exception in app/code/core/Mage/Checkout/Model/Cart/Shipping/Api.php where the typo was also fixed.

Related Pull Requests

None

Fixed Issues (if relevant)

Not relevant

Manual testing scenarios (*)

No testing scenarios required

Questions or comments

Since I've stumbled across this typo a few times, I thought it was time to fix it. :)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Backup Relates to Mage_Backup Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: lib/Zend Component: lib/* Relates to lib/* Component: Media Relates to Mage_Media Component: Payment Relates to Mage_Payment Component: ProductAlert Relates to Mage_ProductAlert Component: Reports Relates to Mage_Reports Component: Review Relates to Mage_Review Component: Sales Relates to Mage_Sales documentation JavaScript Relates to js/* labels Jan 28, 2022
luigifab
luigifab reviewed Jan 28, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Flyingmana Flyingmana merged commit 6b705e4 into OpenMage:1.9.4.x Jan 31, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 6b705e4. ± Comparison against base commit f09b664.

@Sdfendor Sdfendor mentioned this pull request Aug 15, 2022
Merged
3 tasks
@sreichel sreichel mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigifab luigifab luigifab left review comments

@kiatng kiatng kiatng approved these changes

@Sdfendor Sdfendor Sdfendor approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

@Sekiphp Sekiphp Sekiphp approved these changes

@elidrissidev elidrissidev elidrissidev approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Backup Relates to Mage_Backup Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: lib/* Relates to lib/* Component: Media Relates to Mage_Media Component: Payment Relates to Mage_Payment Component: ProductAlert Relates to Mage_ProductAlert Component: Reports Relates to Mage_Reports Component: Review Relates to Mage_Review Component: Sales Relates to Mage_Sales documentation JavaScript Relates to js/*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tmewes @kiatng @Sdfendor @ADDISON74 @Sekiphp @luigifab @elidrissidev @Flyingmana