Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpdocs: Undefined methods #2613

Merged
merged 4 commits into from
Sep 21, 2022
Merged

phpdocs: Undefined methods #2613

merged 4 commits into from
Sep 21, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 21, 2022

Description (*)

Want to finish (or at least continue) with #416 (docblocks/better IDE support and common CS fixes) ... Mage/Adminhtml is to large to do it with one PR, so i try to split it for easier reviews,

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@sreichel sreichel added Cleanup: DOC blocks Related to DOC block updates and fixes. Cleanup: Code style Related to simple CS fixes. and removed Cleanup: DOC blocks Related to DOC block updates and fixes. labels Sep 21, 2022
@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog Component: Core Relates to Mage_Core Component: Rss Relates to Mage_Rss Component: Sales Relates to Mage_Sales labels Sep 21, 2022
@fballiano fballiano merged commit 5a3e2c3 into OpenMage:1.9.4.x Sep 21, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 5a3e2c3. ± Comparison against base commit 37642ed.

@sreichel sreichel deleted the undefined-methods branch September 21, 2022 19:44
@sreichel sreichel mentioned this pull request Dec 15, 2022
@sreichel sreichel restored the undefined-methods branch December 15, 2022 21:28
@sreichel sreichel deleted the undefined-methods branch December 16, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup: Code style Related to simple CS fixes. Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog Component: Core Relates to Mage_Core Component: Rss Relates to Mage_Rss Component: Sales Relates to Mage_Sales
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants