-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPMD: added basic config #2771
Conversation
do we need it? does things that phpstan does not? because now we're adding a lot of "suppress warning" which... I don't like. |
Do we need codesyle checks or phpstan? Imho phpmd is a great tool to improve code.
Yes. Its completly different. phpstan checks for working code, phpmd for clean (not messed up) code.
Add "suppress warning" shows that the "problematic" code is intentional - or needs to be reviewed. I'd like to enable checks step by step ... regardless of adding some lines to phpdocs. |
ok I see, but still, we're not going to add "suppresswarning" to every method just to remove it later one by one right? |
Nope. It should only be added for code that cant be changed. |
Description (*)
Last tool to add ... PHPMD
@
operatorTodo (new PRs)
Test
vendor/bin/phpmd app/code/core/Mage/ text .phpmd.dist.xml
Contribution checklist (*)