Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPStan: removed excluded directories #2790

Merged
merged 1 commit into from
Dec 7, 2022
Merged

PHPStan: removed excluded directories #2790

merged 1 commit into from
Dec 7, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 6, 2022

Description (*)

Removed excluded paths from phpstan config and added lib/Varien to avoid errors like #2788. Ignored files will be checked later again. Fixed only a few things ... everything else in baseline for next days.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Usa Relates to Mage_Usa Component: Weee Relates to Mage_Weee phpstan labels Dec 6, 2022
@fballiano fballiano merged commit 593502e into OpenMage:1.9.4.x Dec 7, 2022
@sreichel sreichel deleted the phpstan-no-exclude branch December 7, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Usa Relates to Mage_Usa Component: Weee Relates to Mage_Weee phpstan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants