Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "was" from error messages #2869

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Conversation

loekvangool
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* labels Dec 30, 2022
@Flyingmana
Copy link
Contributor

Is the text somewhere covered/used in translations?

@loekvangool
Copy link
Contributor Author

No I don't believe so. Looking at the codebase I don't see that many translated exceptions (I do see some). Would you like this to be translatable?

@fballiano
Copy link
Contributor

If they only end up in log files i think they shouldn’t be translated

@fballiano fballiano merged commit f733f1e into OpenMage:1.9.4.x Dec 30, 2022
@loekvangool loekvangool deleted the patch-5 branch January 2, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants