-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DEV_PHP_STRICT env variable #2882
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADDISON74
previously approved these changes
Jan 2, 2023
elidrissidev
reviewed
Jan 2, 2023
Flyingmana
previously requested changes
Jan 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs documentation/explanation in code.
Having also a mention in the Readme or our Docs would be nice to have.
This reverts commit 7909795.
ADDISON74
previously approved these changes
Jan 2, 2023
elidrissidev
approved these changes
Jan 3, 2023
ADDISON74
approved these changes
Jan 3, 2023
fballiano
pushed a commit
that referenced
this pull request
Jan 3, 2023
* Show all errors * Update * Revert "Update" This reverts commit 7909795. * Added comment * Updated README.md * Typo
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
When testing against PHP8.1 you have to comment some lines, mentioned in related PRs.
PR adds support for
DEV_PHP_STRICT
env variable to not change functions.php every time.DDEV example:
Related Pull Requests
Contribution checklist (*)