Ensure null value not passed to str_replace #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default configuration values may be of null value, and should be typecasted to a string before passing to the str_replace function
mattdavenport
force-pushed
the
fix/php8.1/config-load-null
branch
from
e75902e
to
4378dcf
Compare
|
Duplicate of #2806. Please keep it open for now. Waiting for review for my PR. |
Sdfendor
approved these changes
Jan 6, 2023
|
Btw ... i agree with tis PR, but if it is possible a w'd avoid type casting (i know its not possible everywhere). |
elidrissidev
approved these changes
Jan 9, 2023
|
Agreed, I think the aforementioned PR is better here. |
|
The other PR is good but it changes the behavior by making config values with null in the database not overriding the default value in xml, if any. See the review comment in the PR. |
|
it seems it would make no harm to merge this PR. it's simple and shouldn't have any side effect |
sreichel
approved these changes
Jan 9, 2023
4 tasks
fballiano
approved these changes
Jan 9, 2023
fballiano
pushed a commit
that referenced
this pull request
Jan 9, 2023
|
cherry-picked to 20.0 since there were no conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typecasing potentially default 'null' configuration values to a string before passing to
str_replace, avoiding PHP 8.1 deprecation warnings.