Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed deprecation warning in Mage_SalesRule_Model_Rule #3188

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Fixed deprecation warning in Mage_SalesRule_Model_Rule #3188

merged 1 commit into from
Apr 18, 2023

Conversation

fballiano
Copy link
Contributor

This PR should fix point number 3 of #3184, super easy, in this case I think a cast should be ok

@github-actions github-actions bot added the Component: SalesRule Relates to Mage_SalesRule label Apr 17, 2023
@fballiano fballiano mentioned this pull request Apr 17, 2023
Closed
@fballiano fballiano merged commit 4874e5c into OpenMage:main Apr 18, 2023
@fballiano fballiano deleted the issue3184_2 branch April 18, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
Component: SalesRule Relates to Mage_SalesRule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fballiano @kiatng @ADDISON74