-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression from getSelectCountSql optimization when collection us… #3279
Merged
fballiano
merged 4 commits into
OpenMage:main
from
colinmollenhour:fix-count-optimization
May 31, 2023
Merged
Fix regression from getSelectCountSql optimization when collection us… #3279
fballiano
merged 4 commits into
OpenMage:main
from
colinmollenhour:fix-count-optimization
May 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es bind parameters in join clauses. Refs OpenMage#2210
github-actions
bot
added
Component: lib/Varien
Relates to lib/Varien
Component: lib/*
Relates to lib/*
labels
May 26, 2023
Hold up.. this needs to account for the fact that bind params can be set with and without the leading ':'.. |
Should be good now. 😄 |
kiatng
previously approved these changes
May 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested:
$collection = Mage::getResourceModel('directory/region_collection');
$collection->addBindParam('id2', 'MY');
$collection->getSelect()->where('main_table.country_id = :id2');
$sql = $collection->getSelectCountSql();
$result = [
$sql->__toString(),
$collection->getSize(),
$collection->toArray(),
]
colinmollenhour
commented
May 30, 2023
kiatng
approved these changes
May 31, 2023
fballiano
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2210
Skips optimization if bound parameters are found in any join conditions.