Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPMD to workflow #3482

Closed
wants to merge 6 commits into from
Closed

Add PHPMD to workflow #3482

wants to merge 6 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Aug 31, 2023

Description (*)

Added PHPMD to worklow.

Related Pull Requests

  1. See PHPMD: added basic config #2771

Manual testing scenarios (*)

  1. ddev phpmd <path>

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@sreichel sreichel changed the title Phpmd Add PHPMD to workflow Aug 31, 2023
@ADDISON74
Copy link
Contributor

@sreichel - Nice to see you creating PRs. Please note there are 1225 warnings reported by PHPMD. Is it OK?

@sreichel
Copy link
Contributor Author

sreichel commented Sep 1, 2023

@ADDISON74 it's okay. Warnings should be fixed before it gets merged, but ... I recognized that I can't comment or even review PRs made by fab ... I'm done.

@sreichel sreichel closed this Sep 1, 2023
@OpenMage OpenMage locked as too heated and limited conversation to collaborators Sep 1, 2023
@OpenMage OpenMage deleted a comment from ADDISON74 Sep 1, 2023
@OpenMage OpenMage deleted a comment from ADDISON74 Sep 1, 2023
@OpenMage OpenMage deleted a comment from Flyingmana Sep 1, 2023
@OpenMage OpenMage deleted a comment from sreichel Sep 11, 2023
@OpenMage OpenMage deleted a comment from fballiano Sep 11, 2023
@OpenMage OpenMage deleted a comment from fballiano Sep 11, 2023
@OpenMage OpenMage deleted a comment from fballiano Sep 11, 2023
@OpenMage OpenMage deleted a comment from fballiano Sep 11, 2023
@OpenMage OpenMage deleted a comment from sreichel Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants